test: integration tests for the tier 1 release fixes

[NickJosevski]

Adds end-to-end integration tests for the four "Tier 1" fixes — the ones whose correctness depends on how the real Octopus Server behaves, which testutil.MockHttpServer cannot validate by construction.

Refs #294, #426, #250, #556.

Why this branch stacks the four fixes

The tests assert post-fix behaviour, so they need the fixes present to pass. This branch merges the four feature branches and adds the tests on top:

Merged	PR
nj/issue-294	#696
nj/issue-426	#695
nj/issue-250	#702
nj/issue-556	#692

This branch is not for merging as-is. It exists to prove the four compose and to carry the new tests. Once the four land on main, the last commit here rebases onto main on its own.

Tests added

All in test/integration/release_test.go, following the existing harness (integration.RunCli, CreateCommonProject, t.Cleanup teardown).

• TestReleaseDeployUnknownVersion — release deploy returned error when using latest as input param for version #294. Asserts the API premise directly (an unknown version yields no usable release), then that release deploy names the version it could not find, and that latest is explained rather than passed through.
• TestReleaseCreateMissingPackageVersion — Unhelpful output when attempting to create a release with a package that doesn't exist #426. Project with a package step whose package has no version in the built-in feed; asserts the failure names the package and the step.
• TestReleaseCreateAndDeployByID — Some arguments do not accept the ID instead of the name #250. release create --channel <Channels-N> lands on that channel; release deploy --environment <Environments-N> produces a deployment in that environment.
• TestReleaseDeployCommaSeparatedTargets — Support comma-delimited values on octopus release deploy --deployment-target command #556. Two cloud-region targets, --deployment-target "A,B", asserts the resulting deployment's SpecificMachineIds contains both.

Verification

Run against a real Octopus Server (local dev instance, server main):

• On this branch: all 4 pass, 20.7s, clean teardown.
• On unmodified main with the same test file: all 4 fail. They are genuine regression tests, not tests that pass either way.
• go build ./... clean; go test ./pkg/... green (63 packages).

Finding: the null-reference symptom no longer reproduces

#294 and #426 both describe Octopus API error: Object reference not set to an instance of an object. []. On a current server that is not what happens:

• release deploy returned error when using latest as input param for version #294 path → Octopus API error: Release 9.9.9 for project <name> was not found. []
• Unhelpful output when attempting to create a release with a package that doesn't exist #426 path → Octopus API error: There are no viable release plans in any channels using the provided arguments... Cannot resolve

The server-side defect appears to have been fixed since those issues were filed (2022.3 and 2024.4 respectively). Both CLI fixes still improve the message materially, and older servers still exhibit the original behaviour — but the premise that the server null-refs is no longer true on current versions. Two consequences:

1. The suggestion in fix: report missing package versions instead of a server null reference #695 to raise a matching Server issue is probably moot; worth confirming before filing.
2. The assert.NotContains(..., "Object reference not set") lines in these tests are not load-bearing on a current server. They are kept as regression guards for older ones; the positive assertions are what carry the tests.

Finding: the four fixes do not compose without test changes

Each of the four is green on its own branch, but merged they break each other's unit tests — invisible on the individual branches by construction. Fixed in the first commit here:

• pkg/cmd/release/deploy/deploy_test.go, 8 conflict hunks: release deploy returned error when using latest as input param for version #294 adds a release pre-flight lookup and Some arguments do not accept the ID instead of the name #250 adds an environment lookup to the same request sequences. Resolved by expecting both, release first, matching the merged resolution order in deployRun.
• The tests added by Some arguments do not accept the ID instead of the name #250 and Support comma-delimited values on octopus release deploy --deployment-target command #556 merged cleanly but had no release pre-flight expectation, so MockHttpServer deadlocked waiting for a request that never came — the full unit suite hung rather than failed.
• Some arguments do not accept the ID instead of the name #250's release deploy specifying project, environment and tenant by ID still expected the two post-deploy web-URL lookups that release deploy returned error when using latest as input param for version #294 removes.
• Support comma-delimited values on octopus release deploy --deployment-target command #556's runbook comma-separated test needed Some arguments do not accept the ID instead of the name #250's environments/all lookup.

None of these are defects in the individual PRs; they are ordinary merge fallout. Flagging them because whichever of the four merges last will hit exactly this, and the failure mode for two of them is a hang, not a red test.

Notes

• test/integration has no build tag and GetApiClient calls os.Exit(999) when OCTOPUS_TEST_URL/OCTOPUS_TEST_APIKEY are unset, so a bare go test ./... from the repo root hard-exits. Run the suite from test/integration.
• The two deploy tests queue a real server task and wait for it to complete, because a project cannot be deleted while one is running. Whether the deployment succeeds is not asserted.
• allowDeploymentsTo restores the fixture lifecycle's phases on cleanup, otherwise the environment cannot be deleted.

🤖 Generated with Claude Code