refactor: reduce cognitive complexity of StarConnector invocation handler - #2894
Open
hongwei1 wants to merge 1 commit into
Open
refactor: reduce cognitive complexity of StarConnector invocation handler#2894hongwei1 wants to merge 1 commit into
hongwei1 wants to merge 1 commit into
Conversation
…dler Extract the delegate-to-stub, route-to-connector, and metric/trace recording logic in the StarConnector InvocationHandler into named local functions. Behaviour is unchanged; this addresses SonarCloud scala:S3776 (cognitive complexity 39, limit 15) flagged on the InvocationHandler introduced when replacing CGLib's MethodInterceptor.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scala:S3776(Cognitive Complexity 39, limit 15, CRITICAL) on theInvocationHandler.invokeintroduced in build: migrate obp-api and obp-commons to Scala 2.13 #2890 when theStarConnectorinterceptor was moved off CGLib'sMethodInterceptoronto a JDKInvocationHandler.invokeintodelegateToStub,routeToConnector,recordConnectorInboundMetrics, andrecordConnectorTrace. No behavioural change — same branching, same metric/trace recording, same correlationId handling (including the existing shadowing inside the trace block).Test plan
mvn -pl obp-api compile— clean buildmvn -pl obp-api test -DwildcardSuites="code.bankconnectors.ConnectorProxyObjectMethodsTest,code.bankconnectors.ProxyConnectorTest,code.connector.InternalConnectorTest"— 14/14 passed