Skip to content

Pace the software decode fixture by decoder admission - #973

Merged
capy-ai[bot] merged 1 commit into
devfrom
capy/pace-the-software-decode
Sep 16, 2026
Merged

capy-ai[bot] merged 1 commit into
devfrom
capy/pace-the-software-decode

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

What changed

The software-decode fixture now waits for each access unit to reach the decoder before submitting the next one, draining output while it waits. The wait uses existing submission diagnostics and has a five-second deadline. Admission must return Queued; dropped input is no longer tolerated by a test that requires contiguous output.

No production code, queue capacities, decoder settings, or frame-continuity assertions changed.

Why

The old fixture submitted a 30 FPS bitstream with an unconditional 1 ms delay. Under scheduler pressure it could overflow bounded queues and then fail its frame-count or timestamp assertions. A controlled burst reproduced an explicit video queue-overflow event. The original also failed all 12 worker stress runs under four CPU spinners; the paced version passed the same workload.

Verification

  • Independent parent replay: 777 bundled-native tests passed, 16 ignored; strict workspace Clippy and formatting passed with linux-ffmpeg-bundled.
  • Independent parent stress replay: 8/8 passes under four CPU spinners.
  • Worker stress coverage: 67/67 fixed runs passed across idle, 4-, 8-, and 16-spinner workloads, plus 6/6 after comment cleanup.
  • Existing frame-count, timestamp continuity, dimensions, NV12/SDR CPU-plane, second-keyframe, and look-ahead assertions remain intact.

This is a separate acceptance-fixture correction discovered during final Sony validation, not a Sony production change.

Open in Capy

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0ce94aff-0667-4ee1-8958-86b8dc3082d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@capy-ai
capy-ai Bot merged commit c1bd5f9 into dev Sep 16, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant