Pace the software decode fixture by decoder admission - #973
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The software-decode fixture now waits for each access unit to reach the decoder before submitting the next one, draining output while it waits. The wait uses existing submission diagnostics and has a five-second deadline. Admission must return
Queued; dropped input is no longer tolerated by a test that requires contiguous output.No production code, queue capacities, decoder settings, or frame-continuity assertions changed.
Why
The old fixture submitted a 30 FPS bitstream with an unconditional 1 ms delay. Under scheduler pressure it could overflow bounded queues and then fail its frame-count or timestamp assertions. A controlled burst reproduced an explicit video queue-overflow event. The original also failed all 12 worker stress runs under four CPU spinners; the paced version passed the same workload.
Verification
linux-ffmpeg-bundled.This is a separate acceptance-fixture correction discovered during final Sony validation, not a Sony production change.