Forward Sony controller input through owned native HID sessions - #974
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Adds the Sony input path to the Qt/native client: complete typed SDL snapshots flow through one shared wire adapter, C ABI 11, bounded native HID state, and the existing reliable NVST control channel. This PR contains only the 38-file Sony delta on merged dev
c1bd5f95. The Windows UDP correction and decoder-fixture pacing fix are already in its base.Ownership and recovery
End-to-end verification
The Linux Qt integration test uses virtual SDL devices, the production
ControllerInput, sharedSonySnapshotWireadapter, realNativeStreamRuntime/FFI, an accepted software-decoding session, and a genuine local ICE/DTLS/SCTP peer. It checks actual received reports, not just queued bytes or an idle runtime.Six scenarios cover buttons/touch/click and both Sony Y signs; negotiated ordinary fallback and Y inversion; capture neutralization with rapid resume; detach/replacement tombstones; selected-second-source logical-zero claims and in-session selection; and peer-originated rumble routed to the selected physical source. Inactive/retired rumble is checked after an exact native post-dispatch receipt and two subsequent ordered cursor events that drain the callback path.
The peer has separate physical/logical ICE addressing, bounded stdin lines/commands and per-iteration work, and an isolated probe-only Cargo build. Its diagnostic capture has owned cleanup and bounded storage. A focused Sony test build explicitly deploys the peer. The ALSA null fixture is explicit, not a developer-machine configuration dependency.
Checks
--features linux-ffmpeg-bundled.Limits
The end-to-end peer is local and the SDL devices are virtual. This does not claim authenticated GFN gameplay or physical USB qualification. G29/HOTAS production support remains blocked on the separately documented physical output, release, identity, and remote-activation gates; this PR does not silently enable or defer those profiles. No nightly signing, tag, version bump, or release is triggered here.