Standardize logging - #48
Open
diondokter wants to merge 6 commits into
Open
Conversation
diondokter
requested review from
felipebalbi,
kurtjd,
tullom and
williampMSFT
September 8, 2026 08:29
alamfarjadf
reviewed
Sep 8, 2026
|
|
||
| if let Some(cmpa_rotkh) = load_rotkh_from_cmpa() { | ||
| parms.soc_RoTNVM.soc_rkh = cmpa_rotkh; | ||
| parms.soc_ro_tnvm.soc_rkh = cmpa_rotkh; |
alamfarjadf
reviewed
Sep 8, 2026
| // Start as unused by default for safety; will be updated with real values from CMPA if read is successful. | ||
| soc_root_key_usage: [NbootRootKeyUsage::Unused; 4], | ||
| soc_root_key_type_and_length: NbootRootKeyType::EcdsaP384Mldsa87, //FIXED TO THIS because we are CNSA 2.0 compliant. | ||
| soc_lifecycle: 0, |
There was a problem hiding this comment.
I know these are supposed to be updated by real values, BUT 0 is not a valid LC state. It should be encoded as the default NBoot LC values (ideally production for a strict start)
Member
Author
|
@alamfarjadf you're reviewing changes from #47 |
alamfarjadf
reviewed
Sep 8, 2026
| parms.soc_RoTNVM.soc_rkh_1.copy_from_slice(&pqc_rkth_words); | ||
| parms.soc_ro_tnvm.soc_rkh_1.copy_from_slice(&pqc_rkth_words); | ||
| } else { | ||
| verify_warn!("Production: image PQC RKTH differs; not copying, will not call verify"); |
There was a problem hiding this comment.
We need to maintain the deinit call, without it the secure Ctx remains intact.
alamfarjadf
reviewed
Sep 8, 2026
|
|
||
| verify_error!("Auth failed with status {:?}: {:?}", status, boot_error); | ||
| Err(boot_error) | ||
| Ok(true) |
There was a problem hiding this comment.
Why wouldn't we want to use the NXP Hamming bit pattern?
felipebalbi
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #47
I tried gh stack because it seems good for this, but apparently it doesn't support cross repo PRs?