Pull in Fix PD CFU timeout recovery- #129 - #133
Merged
Merged
Conversation
Publish interrupt flags before clearing W1C state so cancellation cannot drop completions. Reconcile commands that finish at timeout and reserve independent TFUc verification slack. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Return completed command values unchanged when timeout reconciliation confirms that the device finished the command. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Import the timeout duration in the extracted Embassy module and keep the ported regression tests formatted for the current main branch. Assisted-by: GitHub Copilot:gpt-5.6-sol Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e056cc40-078a-46ce-8af7-2902eb5a828f
RobertZ2011
force-pushed
the
pull-in-129
branch
from
September 14, 2026 17:51
7909080 to
e8a9277
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical timeout-reconciliation and public API compatibility issues remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Improves PD CFU timeout recovery, TFUc timeout handling, and interrupt-clear resilience.
Changes:
- Adds TFUc verification timeout slack.
- Tracks and retries pending interrupt clears.
- Reconciles timed-out command results and adds tests.
File summaries
| File | Summary and findings |
|---|---|
src/command/mod.rs |
Adjusts TFUc timeout calculation. |
src/asynchronous/internal/mod.rs |
Tracks pending interrupt clears. Moderate (3 votes): Removing clear_interrupt breaks downstream users; retain a compatibility wrapper or document the breaking change. |
src/asynchronous/embassy/mod.rs |
Adds timeout reconciliation and tests. Critical (2 votes): Reconciliation may read stale command status if submission did not complete; only reconcile after confirmed CMD1 submission. |
src/asynchronous/embassy/interrupt.rs |
Publishes interrupts before clearing and adds retry handling. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RobertZ2011
marked this pull request as ready for review
September 14, 2026 18:25
RobertZ2011
enabled auto-merge (squash)
September 14, 2026 18:25
RobertZ2011
requested review from
jerrysxie,
kurtjd,
tullom and
williampMSFT
September 14, 2026 18:29
kurtjd
approved these changes
Sep 14, 2026
RobertZ2011
marked this pull request as draft
September 14, 2026 22:42
auto-merge was automatically disabled
September 14, 2026 22:42
Pull request was converted to draft
RobertZ2011
marked this pull request as ready for review
September 15, 2026 15:50
jerrysxie
requested changes
Sep 16, 2026
RobertZ2011
enabled auto-merge (squash)
September 16, 2026 18:04
jerrysxie
approved these changes
Sep 16, 2026
tullom
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.