xm530: add anbiux A8B-3MP (IPC-RB-BLK530AI, ATBM6032 USB WiFi) - #130
Open
yatotoshka wants to merge 2 commits into
Open
xm530: add anbiux A8B-3MP (IPC-RB-BLK530AI, ATBM6032 USB WiFi)#130yatotoshka wants to merge 2 commits into
yatotoshka wants to merge 2 commits into
Conversation
yatotoshka
requested review from
ZigFisher,
cronyx,
flyrouter,
viktorxda and
ystinia
as code owners
August 26, 2026 14:03
PR Summary by QodoAdd Anbiux A8B-3MP XM530 profile and custom firmware source
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo
1. Nightly builders cannot make this image
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
| BR2_PACKAGE_LIBEVENT_OPENIPC=y | ||
| BR2_PACKAGE_LIBOGG_OPENIPC=y | ||
| BR2_PACKAGE_LINUX_FIRMWARE_OPENIPC=y | ||
| BR2_PACKAGE_LINUX_FIRMWARE_OPENIPC_MEDIATEK_MT7601U=y |
There was a problem hiding this comment.
1. Remove unused mt7601u firmware 📘 Rule violation ⚙ Maintainability
5
The device defconfig enables MediaTek MT7601U firmware even though this board uses the AltoBeam ATBM6032 USB radio. This adds unrelated payload to an 8 MB image whose device-specific exclusions already prune other unused WiFi stacks for space.
Agent Prompt
## Issue description
The device defconfig selects MT7601U firmware that is not used by the board's ATBM6032 radio.
## Issue Context
The device is configured for `atbm60xx` over USB and uses `atbm603x-xm530-usb`; the extra MediaTek firmware conflicts with the requirement to keep device payload minimal, especially for the configured 8 MB flash.
## Fix Focus Areas
- devices/xm530_lite_anbiux-a8b-3mp/br-ext-chip-xiongmai/configs/xm530_lite_anbiux-a8b-3mp_defconfig[61-62]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
yatotoshka
force-pushed
the
xm530-lite-anbiux-a8b-3mp
branch
from
August 26, 2026 14:44
adc174d to
eb208b1
Compare
The defconfig selects the atbm60xx driver (603x, USB) on top of xm530_lite, and drops the MT7601U firmware this radio does not use. The customizer sets wlandev to the atbm603x-xm530-usb case in firmware's /etc/wireless/usb and wifipdn to the PDN gpio (after which S40network applies the MAC and runs ifup), and points the upgrade url at this device's builder release. Depends on OpenIPC/firmware#2316: it provides the bring-up case, the depmod pass that makes the driver stack resolvable by modprobe, and the cfg80211 coexistence (the vendor rewrite ships as cfg80211_xm711.ko, atbm60xx uses the in-tree module). xm530_lite_anbiux-a8b-3mp joins SMOKE_TARGETS: the vendor:xiongmai trait must be covered or ci-matrix.py's self-test refuses to select a build matrix.
yatotoshka
force-pushed
the
xm530-lite-anbiux-a8b-3mp
branch
from
August 26, 2026 14:50
eb208b1 to
e8f06b6
Compare
yatotoshka
marked this pull request as draft
August 27, 2026 14:02
yatotoshka
marked this pull request as ready for review
August 27, 2026 14:02
|
Code review by qodo was updated up to the latest commit e8f06b6 |
builder.sh hardcoded the OpenIPC/firmware clone URL, so a device could
never be built against a fork carrying unmerged changes (e.g. the
xiongmai ATBM6032 USB WiFi branch). Route the clone through
${OPENIPC_FW_REPO:-https://github.com/OpenIPC/firmware.git} and expose
it as the firmware_repo input of build-one, next to firmware_ref.
7 tasks
yatotoshka
marked this pull request as draft
September 6, 2026 20:59
yatotoshka
marked this pull request as ready for review
September 6, 2026 20:59
|
Code review by qodo was updated up to the latest commit 826ab1d |
yatotoshka
marked this pull request as draft
September 7, 2026 16:17
yatotoshka
marked this pull request as ready for review
September 7, 2026 16:17
Comment on lines
+49
to
+51
| BR2_PACKAGE_ATBM60XX=y | ||
| BR2_PACKAGE_ATBM60XX_MODEL_603X=y | ||
| BR2_PACKAGE_ATBM60XX_INTERFACE_USB=y |
There was a problem hiding this comment.
1. Nightly builders cannot make this image 📘 Rule violation ☼ Reliability
8
xm530_lite_anbiux-a8b-3mp_defconfig selects the ATBM60XX USB package supplied only by the stated unmerged firmware dependency, while builder.sh defaults to upstream OpenIPC firmware. When pull-request or nightly CI selects this target without OPENIPC_FW_REPO and OPENIPC_FW_REV, the required XM530 driver and bring-up path are unavailable and no functional archive can be produced.
Agent Prompt
## Issue description
The new device requires firmware changes that are not present in the upstream repository cloned by automated builds.
## Issue Context
The manual `build-one` workflow exposes repository and revision overrides, but the regular PR and nightly workflow invokes `builder.sh` without them. Ensure the dependency is merged upstream before this device is registered, or provide a suitably pinned compatible firmware source for this target in automated CI.
## Fix Focus Areas
- devices/xm530_lite_anbiux-a8b-3mp/br-ext-chip-xiongmai/configs/xm530_lite_anbiux-a8b-3mp_defconfig[49-51]
- .github/workflows/master.yml[189-217]
- builder.sh[129-143]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
Code review by qodo was updated up to the latest commit 826ab1d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
No XM530 device exists in builder. This camera (anbiux A8B-3MP, board
IPC-RB-BLK530AI-0235P-AB0 V1.03, XM530AI + SmartSens SC3335) carries an
AltoBeam ATBM6032 USB WiFi (007a:8888) with power-down on gpio 96; the stock
xm530_liteimage has neither the driver nor a bring-up path for it.What this change does
Device profile
xm530_lite_anbiux-a8b-3mp(commit e8f06b6):xm530_lite_anbiux-a8b-3mp_defconfig— a snapshot ofxm530_lite_defconfigplus
atbm60xx(603x, USB), and with the MT7601U firmware dropped (thisradio is not an MT7601U).
customizer.sh— on first boot setswlandev=atbm603x-xm530-usb(thebring-up case in firmware's
/etc/wireless/usb),wifipdn=96(the casereads the PDN gpio from the
wifipdnenv at run time), and the upgrade urlto this device's builder release, so the Web UI update keeps pulling this
device's image; reboots after 3 s.
xm530_lite.list— prunes the wifi stacks this radio does not use (xm711 +its compat shim, 8188fu) to leave room for the atbm60xx module in the 5M
rootfs.
ci-matrix.py— joinsSMOKE_TARGETS(thevendor:xiongmaitrait must becovered or the matrix self-test refuses to select a build matrix) and the
README device table gets its row.
Build support (commit 826ab1d):
builder.sh— the firmware clone is routed through${OPENIPC_FW_REPO:-https://github.com/OpenIPC/firmware.git}; with thevariable unset the behaviour is exactly as before.
build-one— newfirmware_repoinput next to the existingfirmware_ref,so a device that depends on unmerged firmware changes can be built against a
fork.
master until xm530: bring up the AltoBeam ATBM6032 USB WiFi chip firmware#2316 is merged; the input is what makes that
build possible (and is generally useful for any cross-repo bisect against a
fork).
Dependency
OpenIPC/firmware#2316 (rebased
on upstream master
317b443d, 2026-09-06; draft until its clean-build path isverified on-device): without it the image has no atbm60xx module, no
/etc/wireless/usbcase, and nodepmodpass over the merged target (thevendor
modules.depleavesdwc_otg/wifi_pdninvisible tomodprobe), sothe radio cannot load. It also makes the vendor
cfg80211rewrite coexist withthe in-tree one instead of over it. This profile keeps the atbm60xx selection
explicit in its defconfig snapshot and adds the per-device parts: first-boot
wlandev/wifipdn, the device upgrade url, and the prune list.Hardware tested on
XM530AI (marking 30WX1), board IPC-RB-BLK530AI-0235P-AB0 V1.03, SmartSens
SC3335, AltoBeam ATBM6032 USB WiFi (007a:8888), PDN on gpio 96, 128GB FAT32
(SDXC) card.
Evidence
Re-verified 2026-09-06 from a factory-clean state (env wiped) on the current
nightly (
master+4c34a66): the chip, PDN gpio 96 and the load order(dwc_otg → wifi_pdn → atbm603x) are proven on this camera — it is associated
and takes a DHCP lease:
The Web UI is reachable over both the Ethernet address (192.168.1.242) and the
Wi-Fi address (192.168.1.243).
Status: the camera currently loads the driver from a prebuilt blob (built from
the same atbm_60xx revision firmware#2316 pins) plus a local init script. The
profile's clean-build path (customizer
wlandev/wifipdn→S40network→ thewireless/usbcase) is what a build of this branch will verify end to end.How to build (before #2316 is merged)
build-onewithplatform=xm530_lite_anbiux-a8b-3mp,firmware_repo=https://github.com/yatotoshka/firmware.git,firmware_ref=xiongmai-atbm60xx-wifi→ publishesxm530_lite_anbiux-a8b-3mp-nor.tgz, the same name the customizer's upgrade urlpoints at.
Scope
processor_flavor_vendor-modelnaming and the minimal-file layout from the READMEOPENIPC_FW_REPOchange is a default-preserving override (unset → identical clone behaviour as before)