Add t31_lite_zte-k545 device profile (ZTE K545, SC4336, ATBM6012B Wi-Fi) - #151
Add t31_lite_zte-k545 device profile (ZTE K545, SC4336, ATBM6012B Wi-Fi)#151tagbug wants to merge 1 commit into
Conversation
PR Summary by QodoAdd ZTE K545 T31 Lite device profile
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1. New camera lacks filesystem exclusions
|
| @@ -0,0 +1,71 @@ | |||
| # Architecture | |||
There was a problem hiding this comment.
1. New camera lacks filesystem exclusions 📘 Rule violation ≡ Correctness
The new devices/t31_lite_zte-k545 profile adds its defconfig but does not contain the required general/scripts/excludes/t31_lite.list. When this profile is assembled, no device-level exclusion data defines which T31 lite assets must be pruned or preserved, including the required sensor and Wi-Fi files.
Agent Prompt
## Issue description
The new device profile is missing its required `t31_lite.list` root filesystem exclusion file.
## Issue Context
Create the exclusion list at the documented device path and ensure it preserves the SC4336 sensor assets and ATBM603X Wi-Fi modules while excluding unused assets.
## Fix Focus Areas
- devices/t31_lite_zte-k545/general/scripts/excludes/t31_lite.list[1-1]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| BR2_OPENIPC_SOC_FAMILY="t31" | ||
| BR2_OPENIPC_SNS_MODEL="sc4336" | ||
| BR2_OPENIPC_VARIANT="lite" | ||
| BR2_OPENIPC_FLASH_SIZE="8" |
There was a problem hiding this comment.
2. Firmware targets wrong flash size 📘 Rule violation ≡ Correctness
BR2_OPENIPC_FLASH_SIZE is set to 8 even though the newly documented K545 hardware has 16 MiB NOR flash. Every build selected through this defconfig therefore uses an 8 MiB target for the 16 MiB board, propagating the incorrect capacity into firmware generation.
Agent Prompt
## Issue description
The K545 defconfig declares an 8 MiB flash target despite the device having 16 MiB NOR flash.
## Issue Context
Set the Buildroot flash-size value to the physical capacity required by the compliance rule, then rebuild and verify the resulting image and partition layout on the K545.
## Fix Focus Areas
- devices/t31_lite_zte-k545/br-ext-chip-ingenic/configs/t31_lite_zte-k545_defconfig[46-46]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistent with existing device profiles and only a minor comment typo was found.
Pull request overview
Adds a new per-device Buildroot overlay profile for the ZTE K545 (Ingenic T31X / SC4336 / ATBM6012B USB Wi‑Fi), aligning with how this repo models device-specific deltas layered onto OpenIPC/firmware.
Changes:
- Introduces
t31_lite_zte-k545Buildroot defconfig enabling the expected SoC/sensor/Wi‑Fi and GPIO PTZ support. - Adds a first-boot
customizer.shto set upgrade URL, Majestic GPIO settings (IR-cut/backlight/audio), and PTZ environment variables. - Adds a Linux patch to adjust MMC card-detect GPIO (PB27 → PB18 / GPIO 50) and documents the device in
README.md.
File summaries
| File | Description |
|---|---|
| README.md | Adds ZTE K545 to the supported-device table. |
| devices/t31_lite_zte-k545/general/package/all-patches/linux/0001-change-mmc-detect-gpio-to-50.patch | Applies the MMC card-detect GPIO change used for this board variant. |
| devices/t31_lite_zte-k545/general/overlay/usr/share/openipc/customizer.sh | Device-specific first-boot configuration (upgrade URL, GPIO mappings, PTZ, memory split). |
| devices/t31_lite_zte-k545/br-ext-chip-ingenic/configs/t31_lite_zte-k545_defconfig | New defconfig for the K545 device profile (T31 lite baseline + ATBM60xx + GPIO motors). |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| cli -s .audio.speakerPinInvert true | ||
| # | ||
| # | ||
| # Set wlan device and credentials if need |
Adds a device profile for the ZTE K545 PTZ camera — Ingenic T31X, SC4336 sensor, 16 MiB NOR, and ATBM6012B USB Wi-Fi.
The K545 shares part of its hardware setup with the existing ZTE K540 profile, but requires its own GPIO/PTZ configuration:
atbm603x-t31-zte-k540Wi-Fi runtime profile.Tested on a physical ZTE K545: the firmware builds, flashes and boots successfully, the device operates normally, and the Majestic WebUI works correctly.
All repository checks pass (
ci-matrix,check-firmware-drift --self-test,lint-cli-paths, and the relevant repository self-tests).