Skip to content

(I003) update usage of variable_filter - #464

Draft
syntron wants to merge 6 commits into
OpenModelica:masterfrom
syntron:I003_filter
Draft

(I003) update usage of variable_filter#464
syntron wants to merge 6 commits into
OpenModelica:masterfrom
syntron:I003_filter

Conversation

@syntron

@syntron syntron commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

update handling of variable_filter

  • use public function ModelicaSystemABC.set_variable_filter() to define

  • process it in ModelicaSystemABC._process_override_data() as command line argument

  • use new processing for variable_filter

  • add unittest test_variable_filter()

@cbu-hw

cbu-hw commented Apr 24, 2026

Copy link
Copy Markdown

I'm not sure what's going on with these masses of huuge PRs (who will review that in finite time?!), if that is an AI running wild or not. On the off chance-that this is some kind of structured stacked-feature way of developing features, have you heard that github now formally supports "stacked pull requests"? https://github.github.com/gh-stack/
Maybe that's something that might be useful for you?

@syntron

syntron commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure what's going on with these masses of huuge PRs (who will review that in finite time?!), if that is an AI running wild or not. On the off chance-that this is some kind of structured stacked-feature way of developing features, have you heard that github now formally supports "stacked pull requests"? https://github.github.com/gh-stack/ Maybe that's something that might be useful for you?

I'm the AI running wild ;-) at the end this set of patches was created over a long time. It started quite small (some discussion in PR #404; development started mid of 2025). The small changes accumulated (and new ideas were added) but I never had it down to the point as commit ready steps. However, to get it into OMPython I had to scale it down to handleable pices. But - due to additional requests / discussions - there are new items added at the top ...

The original code is spitted into even smaller commits which show some of the try-and-error development; I reworked it (see: https://github.com/syntron/OMPython/tree/syntron_RFC) and asked if these small commits could be merged into 'steps' of single commit PRs to keep the rebase work low.

The stacked PR idea sounds fine - but is is at the moment not rolled out :-(

@syntron
syntron force-pushed the I003_filter branch 2 times, most recently from 65c300c to 7d70497 Compare May 13, 2026 16:00
@syntron
syntron force-pushed the I003_filter branch 4 times, most recently from e0e26ff to 3c47be4 Compare June 30, 2026 19:50
@syntron
syntron force-pushed the I003_filter branch 3 times, most recently from d2f563e to 4e0f8fd Compare August 14, 2026 17:04
* use public function `ModelicaSystemABC.set_variable_filter()` to define
* process it in `ModelicaSystemABC._process_override_data()` as command line argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants