Skip to content

Fix iconv linking for MinGW builds #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FakeByte merged 1 commit into from
Aug 28, 2026
Merged

Fix iconv linking for MinGW builds #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,8 @@ if(APPLE)
# converter uses iconv. PUBLIC: executables linking this static library
# need them on their own link lines.
target_link_libraries(openvic-dataloader PUBLIC "-framework CoreFoundation" iconv)
elseif(MINGW)
target_link_libraries(openvic-dataloader PUBLIC iconv)
endif()
set_target_properties(openvic-dataloader PROPERTIES ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/$<CONFIG>")

Expand Down
Loading