add multi submitter id validation - #67
Open
edsu7 wants to merge 2 commits into
Open
Conversation
- edit options.json to reflect new variable - change IDs from string to array - example for multi array
Open
4 tasks
lindaxiang
reviewed
Aug 31, 2026
| range: string | ||
| required: true | ||
| pattern: ^[A-Za-z0-9\-\._]{1,64} | ||
| submitter_participant_ids: |
Contributor
There was a problem hiding this comment.
Any reason we fully duplicated slot definitions rather than using is_a slot inheritance feature, e.g,
submitter_participant_ids:
is_a: submitter_participant_id
name: submitter_participant_ids
description: A list of unique identifiers (min 1) for participants within the study, assigned by the data provider.
multivalued: true
minimum_cardinality: 1
list_elements_unique: true
lindaxiang
reviewed
Aug 31, 2026
| - variant_calling_strategy | ||
| - variant_class | ||
| slot_usage: | ||
| submitter_analysis_id: |
Contributor
There was a problem hiding this comment.
change to submitter_analysis_ids?
lindaxiang
reviewed
Aug 31, 2026
| rank: 1 | ||
| slot_group: Database Identifiers | ||
| submitter_experiment_id: | ||
| name: submitter_experiment_id |
Contributor
There was a problem hiding this comment.
submitter_experiment_ids?
lindaxiang
reviewed
Aug 31, 2026
| rank: 2 | ||
| slot_group: Database Identifiers | ||
| submitter_participant_id: | ||
| name: submitter_participant_id |
Contributor
There was a problem hiding this comment.
submitter_participant_ids
lindaxiang
reviewed
Aug 31, 2026
| rank: 3 | ||
| slot_group: Database Identifiers | ||
| submitter_sample_id: | ||
| name: submitter_sample_id |
lindaxiang
reviewed
Aug 31, 2026
| rank: 4 | ||
| slot_group: Database Identifiers | ||
| submitter_specimen_id: | ||
| name: submitter_specimen_id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using endpoint:
https://file-manager.submission.ingress.dev.k8s.pcgl.dev-sd4h.ca/submit/PCGLST0003?allowDuplicates=true
1. String instead of array
Result:
2. Duplicate items
Result:
3. Non-existent record
Result: