Add custom checks stores & storage checks - #5668
Merged
Merged
Conversation
Member
Member
|
@rbev I think there is a misunderstanding here. |
rbev
force-pushed
the
rhys/sql-customchecks2
branch
from
July 31, 2026 05:42
4c78340 to
f9804f5
Compare
rbev
commented
Jul 31, 2026
| Status = c.Status, | ||
| ReportedAt = c.ReportedAt, | ||
| FailureReason = c.FailureReason | ||
| }).ToList(), new QueryStatsInfo("", page.Count, false)); |
Contributor
Author
There was a problem hiding this comment.
Etag left blank, it will be revisited as part of other work.
johnsimons
requested changes
Jul 31, 2026
johnsimons
approved these changes
Aug 3, 2026
johnsimons
left a comment
johnsimons
left a comment
Member
There was a problem hiding this comment.
I have approved it but read my latest comments
rbev
force-pushed
the
rhys/sql-customchecks2
branch
from
August 3, 2026 01:02
877d301 to
078a082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for storing custom check data in both PostgreSQL and SQL Server EF Core persistence layers. It introduces new migration files and updates the database model snapshots to include a new
CustomCheckstable. Additionally, there are minor updates to the .NET SDK version and some code organization improvements.Database schema changes:
custom_checkstable for PostgreSQL and aCustomCheckstable for SQL Server, including columns for IDs, category, status, timestamps, failure reasons, and endpoint information. [1] [2]PostgreSqlServiceControlDbContextModelSnapshot.cs,SqlServerServiceControlDbContextModelSnapshot.cs) to reflect the addition of theCustomCheckEntityand its mapping to the new tables. [1] [2]CustomCheckstable.Build and configuration updates:
global.jsonfrom10.0.100to10.0.302and changed therollForwardpolicy todisable.Code and dependency improvements:
using CustomChecks;directives to relevant files for clarity and to ensure correct namespace usage. [1] [2]SqlServerPersistenceinstance.