Fix custom item mod sections not hiding properly - #10175
Open
Trifall wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10169
Description of the problem being solved:
In the Items tab, adding a crafted or custom modifier to an item and then saving it left the crafted mod line and its "Remove" button stuck on screen behind the helper text.
Added a visibility handler on 'displayItemSectionCustom' that returns whether a display item is present, matching the way the other UI elements' visibility is controlled.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Edit the Helical Ring -> Save -> 'Remove' buttons now incorrectly showing overlapped with the helper text.
Before screenshot:
After screenshot: