Add support for corrupting with more than two modifiers - #10206
Draft
vaisest wants to merge 13 commits into
Draft
Conversation
vaisest
marked this pull request as draft
August 12, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
This adds support for creating items with more corrupted implicit modifiers. Useful for:
This was done by parsing the "can be modified while corrupted" as
mod("CorruptImplicitCount", "BASE", 5this is definitely not technically correct, but since the vestigial implicit and all the other items have that modifier, I think this is the cleanest way of doing this. I would assume that if GGG nerfs this count, they will also change the vestigial implicit wording, and we can easily parse the "can have up to 5 implicit modifiers" line.Note that this depends on #10156, but was separated because it mixes non-vestigial stuff in
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
2 selectors
After screenshot: