fix(gc-ratchet): recover main baseline and surface scheduled failures - #9837
fix(gc-ratchet): recover main baseline and surface scheduled failures#9837proggeramlug wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe GC ratchet recovery updates probe measurements, accepted baseline data, validation for rounded distributions, and evidence for nondeterministic capacity. It also adds serialized incident reporting for eligible main-branch workflow runs and expands test discovery and coverage. ChangesGC ratchet recovery
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The probe exclusion is backed by applicable same-binary evidence, and no merge-blocking issue remains. Sequence Diagram(s)sequenceDiagram
participant MainWorkflow
participant GCRatchetGate
participant report_gc_ratchet
participant GitHubIssues
MainWorkflow->>GCRatchetGate: run GC ratchet checks
GCRatchetGate-->>MainWorkflow: success or failure result
MainWorkflow->>report_gc_ratchet: pass run ID and result
report_gc_ratchet->>GitHubIssues: read run, jobs, logs, and issue state
report_gc_ratchet->>GitHubIssues: create or update failure issue
report_gc_ratchet->>GitHubIssues: close issue after a newer successful run
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 9.68% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 31 functions across 5 files. (7 skipped: 7 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Landed on |
Summary
Main's shared-CI GC ratchet had 43 baseline breaches and an inert receiver-store probe. This restores the gate with a live probe, a selective baseline receipt, and scheduled-failure reporting, without a version bump.
Changes
The recovery record and accompanying JSON contain the per-cell receipt, raw samples, hashes, and evidence grades. Eight fresh historical builds confirm adjacent-commit effects from #8657, #8806, #8900, and #9373. The September 1 attribution is corrected from #9359 to #9373. Remaining window-level explanations are explicitly marked bracketed, following the issue's completed classification; they are not presented as isolated bisections.
The original quiet-host RSS/timing values remain intact. The resized workload needs a separate capture on that original host before using the
pinned_hosttiming profile. The public Node/Bun baseline is unchanged.Related issue
Fixes #9829.
Fixes #9834.
Includes the probe repair proposed in #9833. Implements the GC-ratchet portion of #9830; monitoring the other workflows remains separate.
Test plan
Development and testing ran over SSH on the requested Linux x86-64 host.
perry,perry-runtime-static, andperry-stdlib-statictogether, with codegen-units=16 and LTO disabled.check --profile shared_ci --allow-platform-mismatch; every probe matches Node 26.5.1. The platform override is local only; CI retains its strict platform check.python3 -m unittest discover -s tests -p 'test*gc_ratchet.py': 115 passed.git diff --checkpass.Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation