Remove dead _solicitation_window alias module - #191
Closed
haas26p-ctrl wants to merge 1 commit into
Closed
Conversation
The deprecated SolicitationWindowTransformer alias already resolves through PEP 562 __getattr__ in __init__.py; the separate module was never imported and only dragged coverage. Document the alias rationale above _DEPRECATED_ALIASES. Closes PhilanthroPy-Project#153.
Author
|
Closing this PR — withdrawing the contribution. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes
philanthropy/preprocessing/_solicitation_window.py, which nothing imported.SolicitationWindowTransformeralready resolves through PEP 562__getattr__in__init__.pyto the same class object asDischargeToSolicitationWindowTransformer.Also moves the alias rationale into the comment above
_DEPRECATED_ALIASES, and updates CHANGELOG + CONTRIBUTORS.Closes #153.
Test plan
_solicitation_window(grep / code search)test ! -f philanthropy/preprocessing/_solicitation_window.pymake ci/make riskcovon maintainer CI