fix: surface invalid encounter timezone errors - #202
Merged
shivamlalakiya merged 1 commit intoSep 9, 2026
Merged
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Removes the unreachable
tz_localizefallback inEncounterRecencyTransformer._parse_dates.When
timezoneis set,pd.to_datetime(..., utc=True)already returns timezone-aware parsed dates, sotz_convert()is the correct path. The old broadexcept Exceptionfallback only made invalidtimezone errors worse by replacing the useful timezone error with a misleading "Already tz-aware" error.
Closes #201.
Checklist
make cipasses locally (lint -> collection -> tests -> coverage >= 92%)__init__.pyCHANGELOG.mdupdated under[Unreleased]CONTRIBUTORS.mdTesting
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 .venv/bin/python -m pytest tests/test_encounter_timezone.py tests/test_preprocessing.py -q.venv/bin/python -m flake8 philanthropy/preprocessing/_encounter_recency.pyI could not run the coverage version locally because pytest coverage hit a local NumPy import-loader issue in this environment before collecting tests. The focused behavior tests pass.