π‘οΈ Sentinel: [HIGH] Remove hardcoded JWT secret fallback - #13
Conversation
Co-authored-by: Pmaster-dev <293764797+Pmaster-dev@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Hardcoded secret fallback ('jwt-secret') in JWT token creation and verification when JWT_SECRET_KEY is not configured.
π― Impact: Attackers could forge valid JWT tokens for any user identity if JWT_SECRET_KEY is omitted from environment settings.
π§ Fix: Explicitly check for JWT_SECRET_KEY in JWTUtils. Prevent token generation (raise RuntimeError) and token decoding (return None) when JWT_SECRET_KEY is missing.
β Verification: Created unit tests in tests/test_auth_utils.py verifying behavior when JWT_SECRET_KEY is missing vs. configured, and verified full test suite passes.
PR created automatically by Jules for task 5828157727268265771 started by @Pmaster-dev