Sync to v2.3.0 - #8
Merged
Merged
Conversation
Brings the Pure fork main from 2.1.2 up to dmann000/fb-powershell main at 2.3.0 (supersedes the stale sync PR #7 that only targeted 2.2.0). Includes everything merged since 2.1.2: the 2.2.0 API version-awareness / capability map, typed write-cmdlet parameters (dmann000#66/dmann000#31), user & group quota cmdlets (dmann000#68/dmann000#34), the query-param centralization (dmann000#51/dmann000#33), the drift-report toolchain, and the 2.3.0 correctness fixes (array-connection remote_names dmann000#91/dmann000#64, RemoteDefaultExports suppression dmann000#93/dmann000#55, HTTP status in errors dmann000#92). Tree verified byte-equal to dmann000/fb-powershell main; customer/PII scrub clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+47
to
+49
| uses: ./.github/workflows/cross-platform-tests.yml | ||
|
|
||
| publish: |
Comment on lines
+50
to
+85
| name: Build and publish | ||
| runs-on: ubuntu-latest | ||
| needs: test | ||
| # Only ever publish from the official upstream repo -- see design notes above. | ||
| if: github.repository == 'PureStorage-OpenConnect/flashblade-powershell' | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v7 | ||
|
|
||
| - name: Check for duplicate version on the Gallery | ||
| id: version_check | ||
| shell: pwsh | ||
| run: | | ||
| $manifest = Import-PowerShellDataFile -Path ./PureStorageFlashBladePowerShell.psd1 | ||
| $localVersion = $manifest.ModuleVersion | ||
| Write-Host "Local ModuleVersion: $localVersion" | ||
|
|
||
| # Check the published (rebranded) package name, not the source module name -- | ||
| # scripts/Publish-Gallery.ps1 publishes as EverpureFBModule. | ||
| $published = Find-Module -Name EverpureFBModule -ErrorAction SilentlyContinue | ||
| if ($published -and $published.Version -eq [version]$localVersion) { | ||
| Write-Host "Version $localVersion is already published on the Gallery -- skipping publish." | ||
| "skip=true" >> $env:GITHUB_OUTPUT | ||
| } | ||
| else { | ||
| Write-Host "Version $localVersion is not yet published -- proceeding." | ||
| "skip=false" >> $env:GITHUB_OUTPUT | ||
| } | ||
|
|
||
| - name: Publish to PowerShell Gallery | ||
| if: steps.version_check.outputs.skip == 'false' | ||
| shell: pwsh | ||
| run: | | ||
| ./scripts/Publish-Gallery.ps1 -Publish -ApiKey $env:PSGALLERY_API_KEY | ||
| env: | ||
| PSGALLERY_API_KEY: ${{ secrets.PSGALLERY_API_KEY }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the Pure fork
mainfrom 2.1.2 → 2.3.0, matchingdmann000/fb-powershellmain. This is the release customers pull from, and it had fallen two releases behind (the prior sync PR #7 only targeted 2.2.0 and was never merged — this supersedes it).What's included (everything merged since 2.1.2)
Assert-PfbApiCapability, plus seven documented-but-unexposed query-parameter enums.New-*/Update-*write cmdlets (Write cmdlets: add typed body/query parameters for 56 New-*/Update-* cmdlets dmann000/fb-powershell#66/Write cmdlets silently drop documented body parameters (~48 New-*/Update-* cmdlets) dmann000/fb-powershell#31);-Attributesretained.-Filter/-Sort/-Limit/-TotalOnlyquery-param handling;-Limit 0now sent (Fix: -Limit ignored under AutoPaginate (#30) dmann000/fb-powershell#48/-Limit is ignored under AutoPaginate — paginator has no running-total guard dmann000/fb-powershell#30, Centralize -Filter/-Sort/-Limit/-TotalOnly query params (#32) dmann000/fb-powershell#49/Centralize -Limit/-Sort/-Filter/-TotalOnly query-param handling in Invoke-PfbApiRequest dmann000/fb-powershell#32, Migrate remaining Get-Pfb* cmdlets to Add-PfbCommonQueryParams (#33) dmann000/fb-powershell#51/Migrate cmdlets to centralized query-param handling dmann000/fb-powershell#33).remote_namesinstead of a deadnameskey that could fan a PATCH/DELETE across all connections (fix(replication): select array connections by remote_names, not the dead names query key dmann000/fb-powershell#91/Deadnamesquery key breaks -Name on five array-connection cmdlets and Update-PfbAsyncLog (unfiltered-PATCH risk falsified by live testing) dmann000/fb-powershell#64);New-PfbFileSystemReplicaLink -RemoteDefaultExports $falsecan now suppress remote default exports (fix(replication): let RemoteDefaultExports suppress remote default exports (#55) dmann000/fb-powershell#93/New-PfbFilesystem: safe-by-default creation (no implicit exports, snapshot dir, or open SMB permissions) dmann000/fb-powershell#55); API errors carry the HTTP status (feat(core): report the HTTP status in API error messages dmann000/fb-powershell#92).Breaking changes (see CHANGELOG)
Update-PfbArrayConnection:-Nameis now an alias of-RemoteName; both together is a bind error.New-PfbFileSystemReplicaLink:-RemoteDefaultExportsis now[Nullable[bool]]; the bare form needs a value.Update-PfbAsyncLog:-Name/-Idremoved (endpoint has no selector).Verification
dmann000/fb-powershellmain(verified via tree-hash).