Skip to content

fix: allow bounded IBKR readiness recovery to complete #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Aug 27, 2026
Merged

fix: allow bounded IBKR readiness recovery to complete #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ jobs:
needs: select-targets
name: deploy (${{ matrix.target.name }})
runs-on: ubuntu-latest
timeout-minutes: 60
# A progressing IB Gateway login may legitimately consume the bounded
# readiness budget (up to 61 minutes). Keep enough runner time for its
# cleanup trap to restore health watchers instead of cancelling mid-flow.
timeout-minutes: 75
strategy:
fail-fast: false
max-parallel: 1
Expand Down
2 changes: 1 addition & 1 deletion tests/test_workflow_shared_config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ grep -Fq '"gcp_project_id": env("LEGACY_GCP_PROJECT_ID", "interactivebrokersquan
grep -Fq 'providers/github-ibkr-gateway-main' "$workflow_file"
grep -Fq 'ibkr-gateway-deploy@interactivebrokersquant.iam.gserviceaccount.com' "$workflow_file"
grep -Fq 'id-token: write' "$workflow_file"
grep -Fq 'timeout-minutes: 60' "$workflow_file"
grep -Fq 'timeout-minutes: 75' "$workflow_file"
grep -Fq 'sync_github_secrets_to_secret_manager:' "$workflow_file"
grep -Fq 'deploy_mode:' "$workflow_file"
grep -Fq 'workload_identity_provider: ${{ env.GCP_WORKLOAD_IDENTITY_PROVIDER }}' "$workflow_file"
Expand Down