Skip to content

feat: add "What Is a CRQC?" blog post and fix Q-Day quantum risk image - #56

Merged
dewabisma merged 2 commits into
mainfrom
blog/what-is-a-crqc-and-qday-image-fix
Sep 17, 2026
Merged

dewabisma merged 2 commits into
mainfrom
blog/what-is-a-crqc-and-qday-image-fix

Conversation

@0xRichard-ship-it

Copy link
Copy Markdown
Collaborator

Adds a new draft post explaining CRQCs, qubit/error-correction basics, attack timing (at-rest vs on-spend), Mosca's inequality, and AI-assisted progress toward breaking ECDSA, in all supported locales. Published as draft (published: false) pending review.

Also swaps in a higher-resolution version of the "practical quantum risk" diagram in the existing "What Is Q-Day?" post, and adds a "crqc" tag to the i18n blog-tag dictionaries across all locales.

Adds a new draft post explaining CRQCs, qubit/error-correction basics,
attack timing (at-rest vs on-spend), Mosca's inequality, and AI-assisted
progress toward breaking ECDSA, in all supported locales. Published as
draft (published: false) pending review.

Also swaps in a higher-resolution version of the "practical quantum
risk" diagram in the existing "What Is Q-Day?" post, and adds a "crqc"
tag to the i18n blog-tag dictionaries across all locales.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dewabisma
dewabisma requested a review from n13 September 16, 2026 02:28

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: REQUEST_CHANGES

Blocking finding:

  • website/src/contents/blogs/en-US/what-is-a-crqc.mdx:100 (and the corresponding YouTubeEmbed line in all eight translations): every newly added what-is-a-crqc.mdx fails the repository's configured Prettier check. Prettier rewrites the one-line component invocation to its multiline form. The Code Quality workflow runs bun run format:check, so this head will fail that gate once the workflow's separate startup failure is resolved. Please run the repository formatter on all nine new MDX files and commit the result.

Validation:

  • Reviewed exact head ee80ef065036ece7c7635c78b1320ebfcbdfec9d against base b62c838ba42d8731a02ed2b4afc5ce4fc7e02106.
  • git diff --check passed.
  • Focused Prettier check failed on all nine new MDX files. The zh-CN.json warning is in unchanged pre-existing sections and is not part of this finding.
  • SITE_BASE_URL=http://localhost:3000 npm run build passed with Astro 6.0.7; the production output correctly excludes the draft article and crqc tag routes.
  • The linked primary sources support the article's quoted resource estimates and AI/error-correction claims; no additional blocking content issue was found.

Prettier reformats the one-line <YouTubeEmbed url=... title=... />
invocation to multiline. Addresses the requested-changes review on
PR #56 (format:check gate).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dewabisma
dewabisma requested review from n13 and removed request for n13 September 17, 2026 02:05

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: APPROVE

The blocking formatting issue from the previous review is resolved. I found no remaining blocking issues.

Validation:

  • Reviewed exact head e70c770b570a524c8f3fd07980246297bc12e4bc against base b62c838ba42d8731a02ed2b4afc5ce4fc7e02106, including the full diff and the incremental formatting commit.
  • git diff --check passed.
  • Focused Prettier checks pass for all nine new what-is-a-crqc.mdx files; all nine locale JSON files parse and define the new crqc label.
  • bun test src/utils/blog-posts.test.ts passed (7 tests).
  • SITE_BASE_URL=http://localhost:3000 bun run build passed and emitted neither the draft article nor crqc tag routes.
  • The new assets render correctly, and spot-checks of the linked primary sources support the article's key resource-estimate and AI/error-correction claims.

GitHub currently reports no checks for this branch. The repository-wide format and SEO-meta commands still report failures in unchanged baseline files/fields; none are introduced by this PR's changed lines.

@dewabisma
dewabisma merged commit db99b5d into main Sep 17, 2026
@dewabisma
dewabisma deleted the blog/what-is-a-crqc-and-qday-image-fix branch September 17, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants