Skip to content

fix: drop v prefix from release tags - #78

Draft
RaulSMS wants to merge 1 commit into
masterfrom
fix/70-drop-v-tag-prefix
Draft

fix: drop v prefix from release tags#78
RaulSMS wants to merge 1 commit into
masterfrom
fix/70-drop-v-tag-prefix

Conversation

@RaulSMS

@RaulSMS RaulSMS commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update publish.yml tag trigger from v* to plain semver patterns ([0-9]+.[0-9]+.[0-9]+ and [0-9]+.[0-9]+.[0-9]+-*), so release tags no longer need a v prefix.
  • Update CONTRIBUTING.md release instructions to match the new tag format.

Closes #70

Note

The "Release to PyPI" tag ruleset (refs/tags/v*, restricting who can push release tags) is a repo setting, not something changeable via this PR — it needs to be updated separately (e.g. to refs/tags/[0-9]*) so the new tag pattern is still gated to maintainers.

Test plan

  • Confirm the ruleset pattern is updated in repo settings before cutting the next release
  • Cut a test release with a plain semver tag (e.g. 0.1.3) and confirm publish.yml triggers and completes successfully

Release tags now match plain semver (e.g. 1.2.3, 1.2.3-rc1) instead of
v-prefixed tags, per user preference expressed in #70.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@RaulSMS

RaulSMS commented Aug 28, 2026

Copy link
Copy Markdown
Owner Author

Rulset to protect unwonted release trigger is updated to:
image

This is intentionally simpler/broader than the two workflow patterns — it just says "any tag starting with a digit," which covers 1.2.3 and 1.2.3-rc1 alike.

@RaulSMS

RaulSMS commented Aug 28, 2026

Copy link
Copy Markdown
Owner Author

On reflection, I'd recommend against merging this and keeping the v prefix on release tags.

Reasons:

Given this, I think the better fix for #70's actual underlying concern (the ruleset pattern) is to leave the v* tag format as-is. Closing this PR without merging unless there's a strong reason to prefer the plain-semver form.

@RaulSMS

RaulSMS commented Aug 28, 2026

Copy link
Copy Markdown
Owner Author

@sharma9012mahesh please see the latest comment, I don't think we should merge this.

@RaulSMS
RaulSMS marked this pull request as draft August 28, 2026 08:00
@sharma9012mahesh

Copy link
Copy Markdown
Collaborator

@sharma9012mahesh please see the latest comment, I don't think we should merge this.

Guess you got a strong argument. Makes sense to drop if off then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use release version without the v prefix

2 participants