Add IDN support - #986
Conversation
45f99f7 to
b6c29d8
Compare
|
@tridge requesting a review |
steadytao
left a comment
steadytao
left a comment
There was a problem hiding this comment.
Apologies, I have been attending to some personal matters recently. This needs careful review against IDNA/punycode behaviour and daemon allow/deny matching semantics before merge. I would want tests covering Unicode input, punycode input, mixed-case hostnames, invalid IDNs and allow/deny matching to make sure this does not widen host access unexpectedly.
|
Tests added |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
8254de4 to
beff021
Compare
|
Ah, can you update the clang informational-latest job as well please? |
rsync can now connect to IDN (internationalized domain name) hosts, and IDN names are recognized in a daemon's hosts allow/deny.
The IDNA mapping folds some non-ASCII characters onto ASCII ones, so running a whole hosts allow/deny token through idn2_to_ascii_8z() could hand back a pattern the admin never wrote: a "＊" (U+FF0A FULLWIDTH ASTERISK) entry came back as "*" and let every host in. Convert label by label instead, keeping an ASCII label byte for byte and using a converted label only when it comes back as a bare A-label. An ASCII-only config now behaves as it did before there was IDN support, and a token that cannot be converted is left alone and so matches nothing. The client side shares the same helper, and neither side truncates a name at its 1024-byte buffer any more. strlower() folds only ASCII now, since its one caller is the hosts allow/deny list, which can hold UTF-8. Adds testsuite/daemon-access-idn and extends testsuite/idn to cover Unicode, punycode, mixed-case and invalid input on both sides.
The client path called idn2_lookup_ul() without IDN2_NFC_INPUT while the daemon path passed it to idn2_to_ascii_8z(). Both normalize either way -- idn2_lookup_ul() ors the flag in itself, and TR46 normalizes as it maps -- but there is no reason for the two calls to read differently, so pass one set of flags from one place. The flag asks libidn2 to normalize the label rather than promising that it already is: it gates the u32_normalize() call, and without it a decomposed label comes back IDN2_NOT_NFC. Adds composed/decomposed cases to testsuite/idn, which sees the exact host name rsync hands out, and a decomposed hosts allow token to testsuite/daemon-access-idn.
|
Done |
|
Cygwin died for some reason and cannot be cancelled. Need to refresh. |
|
Is the test order non-deterministic...? (I don't think so) |
Some tests are flaky. Working on this under #1059 when I have time. |
|
Thanks a lot for your work! |
2 participants
rsync can now connect to IDN (internationalized domain name) hosts, and IDN names are recognized in a daemon's hosts allow/deny.
Closes #851.