aes: disable soft backend if not needed - #593
Closed
Freax13 wants to merge 1 commit into
Closed
Conversation
Freax13
force-pushed
the
disable-soft-backend
branch
from
September 8, 2026 12:30
02ad9ad to
18b1e36
Compare
Freax13
marked this pull request as draft
September 8, 2026 12:31
Freax13
force-pushed
the
disable-soft-backend
branch
3 times, most recently
from
September 8, 2026 12:44
730c540 to
09de661
Compare
Previously, the soft backend was always enabled even when the target supports one of the accelerated backends. This is a problem because the soft backend uses a lot of memory for the round keys. Disabling the soft backend when it's not needed saves a lot of memory: On a modern AMD64 system, Aes256Enc now only requires 240 bytes instead of 960 bytes.
Freax13
force-pushed
the
disable-soft-backend
branch
from
September 8, 2026 12:51
09de661 to
a55bdbd
Compare
Freax13
marked this pull request as ready for review
September 8, 2026 12:54
Member
Author
Member
Yes, this is why we did not implement it as well despite being aware of the problem. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the soft backend was always enabled even when the target supports one of the accelerated backends. This is a problem because the soft backend uses a lot of memory for the round keys.
Disabling the soft backend when it's not needed saves a lot of memory: On a modern AMD64 system, Aes256Enc now only requires 240 bytes instead of 960 bytes.