Skip to content

Implement Zeroize for EncodedUint - #1342

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
jplatte:zeroize-encoded-uint
Sep 11, 2026
Merged

Implement Zeroize for EncodedUint#1342
tarcieri merged 1 commit into
RustCrypto:masterfrom
jplatte:zeroize-encoded-uint

Conversation

@jplatte

@jplatte jplatte commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Noticed that this was missing when trying to upgrade crypto-bigint in aws-sigv4.

@jplatte
jplatte force-pushed the zeroize-encoded-uint branch from 0f2a687 to b0c55f6 Compare September 10, 2026 22:06
@jplatte
jplatte marked this pull request as ready for review September 10, 2026 22:07
@codecov

codecov Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.05%. Comparing base (f1225db) to head (b0c55f6).

Files with missing lines Patch % Lines
src/uint/encoding.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
- Coverage   91.06%   91.05%   -0.02%     
==========================================
  Files         189      189              
  Lines       22654    22657       +3     
==========================================
  Hits        20630    20630              
- Misses       2024     2027       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri tarcieri changed the title Add impl Zeroize for EncodedUint Implement Zeroize for EncodedUint Sep 11, 2026
@tarcieri

tarcieri commented Sep 11, 2026

Copy link
Copy Markdown
Member

Note: I've logged the unrelated proptest failure here: #1343

@tarcieri
tarcieri merged commit 67aecbd into RustCrypto:master Sep 11, 2026
90 of 94 checks passed
@jplatte
jplatte deleted the zeroize-encoded-uint branch September 11, 2026 20:00
@jplatte

jplatte commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the quick merge! Is there going to be a patch release soon / would it help for me to do a release prep PR collecting changes since the last release into the changelog and bumping the version?

@tarcieri

Copy link
Copy Markdown
Member

#1343 seems like an important enough issue it would be good to get resolved before the next release, and also "release prep" PRs by third parties are generally unhelpful for us and often create more work than just letting us do the release ourselves (e.g. now we have to review that PR and decide if it's good enough and if it's not generally close it and do our own release PR, which wastes more time than just letting us do the latter)

@jplatte

jplatte commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Okay, I will just wait then. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants