Open telemetry - #87
Merged
Merged
Conversation
…ssage from the actual performance of that act, so the latter can happen in one place, along with the new telemetry.
detail for telemetry anyway
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #87 +/- ##
==========================================
- Coverage 52.74% 50.44% -2.31%
==========================================
Files 13 14 +1
Lines 510 563 +53
Branches 43 47 +4
==========================================
+ Hits 269 284 +15
- Misses 226 263 +37
- Partials 15 16 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skeating
approved these changes
Aug 24, 2026
skeating
left a comment
skeating
left a comment
Collaborator
There was a problem hiding this comment.
Seems ok to me but I have not tested it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds telemetry to the existing
waveform-controllerandwaveform-exportercontainers. Counts incoming messages and FTP uploads.Adds a separate
waveform-monitoringcontainer for monitoring disk usage on a crontab.Adds an lgtm container as a local test and stand-in for the Otel collector that will exist on each GAE very shortly.
No dashboards defined here.
controller.pynew line 154 might be a good place to start reviewing; it has been refactored so that telemetry and message ack/nack can be handled in one place.