Fix multiple FTPS upload issues - #90
Open
jeremyestein wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #90 +/- ##
==========================================
+ Coverage 50.44% 51.07% +0.63%
==========================================
Files 14 14
Lines 563 605 +42
Branches 47 48 +1
==========================================
+ Hits 284 309 +25
- Misses 263 280 +17
Partials 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You always receive one email notification per file uploaded, even if sent on the same connection.
The only reasonable workaround is to tar up the files to be uploaded, which this PR implements. So this fixes the underlying problem described by #67 , using a slightly different method.
Also have fixed #74 by handling remote paths properly.
It also works around #68 because now there will never be duplicate named uploads. It shifts this problem to the DSH extractor script, described in #84