Update chunk size and add named columns - #231
Merged
Merged
Conversation
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the default chunk size of the compressed catalogues to be
4096following some investigation after the helpful suggestion in #200. This has the added benefit of speeding up the copying part of the compression script by a factor of ~5, so this also addresses #129.This PR also adds named columns to SOAP as suggested in #199. The values are directly copied across from the named columns metadata in the snapshots. Swiftsimio will need a very minor update (the SOAPMetadata object should call load_named_columns), but I think we should hold off on doing this until we patch the existing COLIBRE catalogues to have named columns.