fix(composer): give emoticons their own cell size and make the merged caps apply - #102
Merged
Conversation
Member
Author
|
Added a second commit: main's The dismissal fired on velocity alone, so a 30px drag could close the viewer if the two pointer samples happened to land close together in time — which is what the Linux runner does and my machine doesn't. A flick now has to travel at least half the swipe threshold as well as exceed the velocity threshold, so a deliberate short drag springs back on any timing. A real flick still dismisses. With both commits, |
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| Deployment successful! | https://pr-102-sable-next.raspy-dream-bb1d.workers.dev | e6ed1a6 | pr-102 |
Sun, 06 Sep 2026 14:17:46 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #92 by @HardenedSteel, which conflicts with #89 and #90 now that both are merged.
Same outcome as #92 — the emoticon tab gets a 48px cell — but against the existing structure instead of moving
--emote-cellinto a.board-bodyblock. That block nested the rules that followed it, which stylelint rejects: a duplicate.board-bodyselector (one already exists at line 605) and twono-descending-specificityviolations, none of them auto-fixable.3.5rem because
cellSizeis the image size and--emote-cellthe button: 48px + 2x4px padding = 56px, the same relationship sticker's 72 has with 5rem.Also repairs two things the merges left on main:
Unused CSS selectorfor the nestedspanandimg, because both elements come from a child component (MediaImage's root span) or a caller's snippet, so scoped CSS never sees them. Both are now:global(...), which is what makes the caps actually apply.Lintis failing on main over this.max-heightbeforemax-width,justify-contentbeforemargin), plus the 6-space indentation in fix(composer): overflowing emotes/stickers #89 and fix(composer): set max size #91.pnpm check0 errors, stylelint clean repo-wide, eslint clean, 176 tests insrc/lib/uipassing.