Skip to content

fix(composer): give emoticons their own cell size and make the merged caps apply - #102

Merged
eleboucher merged 2 commits into
mainfrom
fix/emote-cell
Sep 6, 2026
Merged

fix(composer): give emoticons their own cell size and make the merged caps apply#102
eleboucher merged 2 commits into
mainfrom
fix/emote-cell

Conversation

@eleboucher

Copy link
Copy Markdown
Member

Supersedes #92 by @HardenedSteel, which conflicts with #89 and #90 now that both are merged.

Same outcome as #92 — the emoticon tab gets a 48px cell — but against the existing structure instead of moving --emote-cell into a .board-body block. That block nested the rules that followed it, which stylelint rejects: a duplicate .board-body selector (one already exists at line 605) and two no-descending-specificity violations, none of them auto-fixable.

.grids.emoji {
  --emote-cell: 3.5rem;
}

3.5rem because cellSize is the image size and --emote-cell the button: 48px + 2x4px padding = 56px, the same relationship sticker's 72 has with 5rem.

Also repairs two things the merges left on main:

pnpm check 0 errors, stylelint clean repo-wide, eslint clean, 176 tests in src/lib/ui passing.

@eleboucher

Copy link
Copy Markdown
Member Author

Added a second commit: main's Tests job is failing on MediaViewer.svelte.test.ts > a short swipe springs back instead of dismissing, and that one is mine.

The dismissal fired on velocity alone, so a 30px drag could close the viewer if the two pointer samples happened to land close together in time — which is what the Linux runner does and my machine doesn't. A flick now has to travel at least half the swipe threshold as well as exceed the velocity threshold, so a deliberate short drag springs back on any timing. A real flick still dismisses.

With both commits, Format check, Stylelint, Lint, Typecheck and Tests should all go green again.

@eleboucher
eleboucher merged commit e6ed1a6 into main Sep 6, 2026
12 of 13 checks passed
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
Deployment successful! https://pr-102-sable-next.raspy-dream-bb1d.workers.dev e6ed1a6 pr-102 Sun, 06 Sep 2026 14:17:46 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant