Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
💥 What does this PR do?
Fixes Python WebSocket response interval validation.
The existing validation checks
timeout < 0twice:As a result, non-positive intervals can pass validation. An interval of -0.1 later reaches sleep(-0.1), while an interval of 0 prevents _wait_until() from reducing its remaining timeout and can cause an infinite loop.
This changes the validation to reject all non-positive interval values:
if not isinstance(interval, (int, float)) or interval <= 0:A unit regression test covers negative, zero, and positive interval values without requiring a browser or WebSocket server.
🔧 Implementation Notes
The interval must be strictly positive because _wait_until() subtracts it from the remaining timeout and passes it to sleep().
🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes