[java] Use one HttpClient.Factory inside one RemoteWebDriver instance - #18038
Merged
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
diemol
reviewed
Sep 16, 2026
diemol
left a comment
diemol
left a comment
Member
There was a problem hiding this comment.
Aside of the comments due to the method remova, looks fine to me.
joerg1985
marked this pull request as draft
September 17, 2026 07:27
joerg1985
force-pushed
the
bidi-client-factory
branch
from
September 17, 2026 14:38
2ab9f3b to
c93e1a3
Compare
joerg1985
force-pushed
the
bidi-client-factory
branch
from
September 17, 2026 14:48
c93e1a3 to
7393ed1
Compare
joerg1985
marked this pull request as ready for review
September 17, 2026 15:04
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
#17814 does restrict the access to
BiDiinternals, but we should in my mind allow to use the sameHttpClient.Factoryused with theCommandExecutorinside theBiDiinternals.💥 What does this PR do?
Allow to pass a
HttpClient.Factoryto theRemoteWebDriverinstance to initialize the client used forBiDi.This PR will also ensure a
TracedHttpClient.Factorywill be used inside theBiDiinitialization, if the tracing flag was set.And some cleanup related to the
HttpCommandExecutorand theHttpClient.Factory.🔧 Implementation Notes
HttpCommandExecutorconstructors and add a new to only pass the clientHttpClient.Factory.cleanupIdleClientsmethod and call it from the client (this can get removed from the interface, as the client knows the factory type, it could call a cleanup method on the type)RemoteWebDriverto pass aCommandExecutorand theHttpClient.Factory🤖 AI assistance
💡 Additional Considerations
🔄 Types of changes