feat(dsv4): add GB300 Dynamo-TensorRT-LLM AgentX recipes / 添加 GB300 Dynamo-TensorRT-LLM AgentX 配置 - #2595
feat(dsv4): add GB300 Dynamo-TensorRT-LLM AgentX recipes / 添加 GB300 Dynamo-TensorRT-LLM AgentX 配置#2595RohitNagraj wants to merge 2 commits into
Conversation
添加 DeepSeek-V4-Pro GB300 Dynamo TensorRT-LLM AgentX 配置与配套配方。
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
1 similar comment
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
在性能变更日志中补充 PR 2595 链接。
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| - "Add a DeepSeek-V4-Pro FP4 Dynamo-TensorRT-LLM MTP AgentX configuration for GB300 with ten disaggregated topologies." | ||
| - "Use NIXL KV transfer, deterministic MTP acceptance settings, and in-repo EPLB placement tables." | ||
| - "Image: nvcr.io/nvidia/tensorrt-llm/release:1.3.0rc24" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX |
There was a problem hiding this comment.
🟡 The new perf-changelog.yaml entry for dsv4-fp4-gb300-dynamo-trt-agentx ends with a placeholder pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX instead of this PR's real number. Since this is PR #2595, the line should read pull/2595; TBD is the only sanctioned pre-PR placeholder per docs/configuration-procedures.md.
Extended reasoning...
The last entry appended to perf-changelog.yaml (for the new dsv4-fp4-gb300-dynamo-trt-agentx config-key introduced by this PR) ends with:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX
XXX is a literal, hardcoded string — it isn't a template variable that gets substituted anywhere, so it resolves to a broken GitHub URL that points at a PR which doesn't exist (there is no PR #"XXX").
docs/configuration-procedures.md documents the expected changelog convention: the pr-link field must follow the .../pull/<number> format, and the only acceptable placeholder before a PR exists is the literal string pr-link: TBD — which must be replaced with the real PR URL immediately once the PR is created. pull/XXX doesn't match either of these: it's neither a valid link nor the sanctioned TBD placeholder, so it violates the documented convention outright.
The code path that "triggers" this is simply: whoever authored the recipe copy-pasted a previous changelog entry as a template and forgot to fill in the actual PR number before generating the diff. Nothing in the repo's tooling currently validates this field at PR-creation time, so a malformed pull/XXX slips through unless a reviewer or CI check catches it — which is presumably why the docs explicitly call out this exact failure mode.
Impact is limited to traceability/documentation: a maintainer or anyone browsing the changelog later to find "which PR introduced this recipe / regression" will follow a dead link instead of landing on the actual PR. It has zero effect on the recipe YAML, the launcher, or benchmark behavior — this is purely a metadata defect in the changelog.
Step-by-step proof:
- Open
perf-changelog.yamland look at the newest (physically last) entry, whoseconfig-keyslist containsdsv4-fp4-gb300-dynamo-trt-agentx(the recipe this PR adds). - Its final field reads
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. - Per the PR metadata, this change is submitted as PR feat(dsv4): add GB300 Dynamo-TensorRT-LLM AgentX recipes / 添加 GB300 Dynamo-TensorRT-LLM AgentX 配置 #2595.
- Compare against sibling entries in the same file (e.g.
pull/2580,pull/2578,pull/2577for the three most-recently-merged PRs before this one) — every other entry uses a real numeric PR id, confirmingpull/XXXis an unintentional leftover rather than an intentional convention. - Fix: change the line to
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2595.
This is a simple one-line fix with no functional risk, so it doesn't block merging, but it should be corrected since the PR's own checklist explicitly calls out maintaining accurate perf-changelog entries.
1 participant
Description
Add a DeepSeek-V4-Pro FP4 Dynamo–TensorRT-LLM AgentX configuration for GB300.
dsv4-fp4-gb300-dynamo-trt-agentxmaster configuration with NIXL KV transfer./scratch/models/DeepSeek-V4-Pro.Validation:
中文说明
为 GB300 添加 DeepSeek-V4-Pro FP4 Dynamo–TensorRT-LLM AgentX 配置。
dsv4-fp4-gb300-dynamo-trt-agentx主配置。/scratch/models/DeepSeek-V4-Pro模型路径。验证：
Related Issue
N/A / 不适用
Type of Change
Checklist
perf-changelog.yamland have not edited historical entriesOWNER/MEMBER/COLLABORATOR) has commented/reuse-sweep-runon this PR. Do this only once there is a final full sweep that is all green with evals passing, since after this comment the sweep label will no longer automatically kick off new sweeps. Remove and re-add the label to force one.