fix(file sink): OBE-10715 confine templated path to a base directory - #158
Open
jsbalis1 wants to merge 1 commit into
Open
fix(file sink): OBE-10715 confine templated path to a base directory#158jsbalis1 wants to merge 1 commit into
jsbalis1 wants to merge 1 commit into
Conversation
An attacker-controlled event field referenced by the `file` sink's `path` template could inject `../` sequences and write to arbitrary filesystem locations outside the intended log directory (CVSS 8.1). Confine rendered paths to a base directory derived from the template's literal prefix (or an explicit `base_dir` override) before any filesystem operation, rejecting and dropping events whose rendered path would escape it. `dangerously_allow_unconfined_template_resolution` opts back out for operators who fully trust every field the template references. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attacker-controlled event field referenced by the
filesink'spathtemplate could inject../sequences and write to arbitrary filesystem locations outside the intended log directory (CVSS 8.1).Confine rendered paths to a base directory derived from the template's literal prefix (or an explicit
base_diroverride) before any filesystem operation, rejecting and dropping events whose rendered path would escape it.dangerously_allow_unconfined_template_resolutionopts back out for operators who fully trust every field the template references.