feat(purl): adopt socketdev 3.4.0 typed batch params - #99
Draft
lelia wants to merge 1 commit into
Draft
Conversation
Migrate the core-tool-watch scoring call in scripts/check_core_tools.py off the stringly-typed query-string kwargs (poll="true"/timeoutSec="120"/ alerts="true") onto the first-class typed params added in socketdev 3.4.0 (poll=True/timeout_sec=120/alerts=True), and bump the socketdev floor to >=3.4.0. Behavior is unchanged (still fail-closed: poll waits for pending analysis, alerts materializes unresolved inputs as synthetic pendingScan/notFound rows), but the intent is now expressed through a supported, typed surface instead of an undocumented passthrough. uv.lock is intentionally NOT regenerated here: socketdev 3.4.0 is not yet on PyPI (SocketDev/socket-sdk-python#98). Regenerate once it publishes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: lelia <2418071+lelia@users.noreply.github.com>
lelia
changed the title
lelia
changed the title
socketdev 3.4.0 typed batch params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The
core-tool-watchscoring call inscripts/check_core_tools.pyopted into the batch purl API's fail-closed semantics via stringly-typed query-string kwargs (poll="true",timeoutSec="120",alerts="true") — an undocumented SDK passthrough. socketdev 3.4.0 promotes these to first-class typed params, so this migrates to the supported surface.Changes
scripts/check_core_tools.py:poll="true"→poll=True,timeoutSec="120"→timeout_sec=120,alerts="true"→alerts=True. Behavior unchanged (still fail-closed).pyproject.toml:socketdev>=3.3.0→socketdev>=3.4.0(typed params require 3.4.0; on 3.3.0timeout_secwould be sent as a literaltimeout_secquery param, silently losing thetimeoutSecfail-closed bound).Not done here (blocked)
uv.locknot regenerated —uv lockcan't resolve>=3.4.0until it's on PyPI. Regenerate once 3.4.0 publishes (Dependabot's weekly uv group will also propose it). Note: core-tool-watch's scan env installs from main'suv.lock, so this takes effect there only after the lockfile bump merges.Sequencing
uv lock, mergeRefs CE-360