DATAGO-147913: Block RC pipeline on unresolved Prisma vulnerabilities - #67
Open
luke-wires wants to merge 1 commit into
Open
DATAGO-147913: Block RC pipeline on unresolved Prisma vulnerabilities#67luke-wires wants to merge 1 commit into
luke-wires wants to merge 1 commit into
Conversation
Adds a Prisma vulnerability gate to prep-release.yml, scoped to internal releases only (external releases don't push an image at this stage, so there's nothing to scan yet - handling that gap is left as an open question for this PR).
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Prisma-based vulnerability gate to the release preparation workflow for internal releases.
Changes:
- Introduced a “Vulnerability Gate - Prisma” step gated by
prep_internal_release. - Configured the step to scan the built operator image and pass Prisma metadata (repo name, squad, JIRA check flag).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Vulnerability Gate - Prisma | ||
| if: ${{ github.event.inputs.prep_internal_release == 'true' }} | ||
| uses: SolaceDev/maas-build-actions/.github/actions/prisma-vulnerability-checker@master |
Author
There was a problem hiding this comment.
Saw this being used in a few other workflows so assumed that was the convention. Can change if necessary
| docker_image_to_check: "${{ env.CONTROLLER_CONTAINER_REPO }}/pubsubplus-eventbroker-operator:v${{ github.event.inputs.release_tag }}" | ||
| prisma_repository_name: "pubsubplus-eventbroker-operator" | ||
| project_squad: "launchpad" | ||
| prisma_jira_check: "False" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SolaceDev/maas-build-actions/.github/actions/prisma-vulnerability-checker) toprep-release.yml, right after the operator image is built/pushed and before bundle/catalog publishing and PR creation.prep_internal_release == trueonly — see open question below.launchpad) andprisma_jira_check: "False"match the same (currently commented-out, unused) config already present inbuild-test-dev.ymlon this repo, and are confirmed correct per the Launchpad squad ownership doc.continue-on-erroron this step, so an unresolved critical/high vulnerability fails the job and blocks the release, per DATAGO-147913.Open question: external releases
prep_internal_release=false(external release prep) never pushes an image at this stage in the workflow — the script assumes the image was already pushed todocker.io/solacebeforehand, and only builds locally (no push) here. There's nothing in a registry for Prisma to check yet at this point in the pipeline, so this gate is scoped to internal releases only for now.Do we want to:
Flagging rather than guessing — feedback welcome before we close this out.
Test plan
prep-release.ymlviaworkflow_dispatchwithprep_internal_release=trueagainst a known-vulnerable image tag and confirm the job fails at the new step.GITHUB_TOKENpermissions (no explicitpermissions:block was added here — flagging in case this needs one).