Skip to content

file explorer context - #851

Merged
SharonStrats merged 3 commits into
stagingfrom
file-explorer-header
Aug 5, 2026
Merged

file explorer context#851
SharonStrats merged 3 commits into
stagingfrom
file-explorer-header

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

create the file explorer context in solid-ui so it can be used in both solid-panes and solid-ui

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a shared Lit context contract for a File Explorer feature and exposes it from the package entrypoint, alongside a small fix to Menu’s item discovery logic to properly ignore only the trigger slotted element.

Changes:

  • Add FileExplorerContext/FileExplorerEdit interfaces and fileExplorerContext (@lit/context) for File Explorer state and callbacks.
  • Export the new context module from src/index.ts as part of the public API.
  • Fix Menu.syncItems() filtering to exclude only slot="trigger" children (instead of excluding all slotted children).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
src/lib/file-explorer/context.ts Adds a new Lit context definition and related TS interfaces for file explorer state/actions.
src/index.ts Re-exports the new file-explorer context from the package entrypoint.
src/components/menu/Menu.ts Adjusts menu item filtering to keep slotted menu items while excluding the trigger element.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SharonStrats
SharonStrats force-pushed the file-explorer-header branch from 8a19958 to 0fcf24f Compare August 5, 2026 07:07
@SharonStrats
SharonStrats merged commit a3f7522 into staging Aug 5, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants