Add possibility to use different passwords for Sentinel and Redis host (#1698)

[doosterkamp]

Adding the possibility to use different passwords for Sentinel and Redis host.
Fixing the long standing issue #1698

Checklist

• I fully and freely contribute this code in accordance with the project license (and am legally able to do so)
• I take responsibility for this contribution's quality and correctness, including any portions produced with AI assistance (see CONTRIBUTING.md).

[mgravell]

Concept is great, +1; a few nits in the ConfigurationOptions piece just because that type is super weird (not your fault), and I'm not a huge fan of the clone usage - I welcome your thoughts there.

[doosterkamp]

Concept is great, +1; a few nits in the ConfigurationOptions piece just because that type is super weird (not your fault), and I'm not a huge fan of the clone usage - I welcome your thoughts there.

Thanks!
I will try to fix the 'nits' today! We really need this fix and are testing with these changes as we speak.
I'm not a huge fan of the clone usage either, but it does the job for now, without a 'big' rewrite of the under-laying code ( I started trying to change that, but it got a lot bigger, very fast, so I stepped back for a moment).

[doosterkamp]

@mgravell is there a nice/correct way to clear the CodeQL security failure or do I need to add an inline suppression message?

[mgravell]

I have dismissed the CodeQL alert; the alert is "right" in that this should be a considered decision, but this is an entirely consistent and appropriateusage.

[mgravell]

super close now; sorry to be pedantic on some of these - I'm not trying to frustrate you

[mgravell]

(note Windows CI may stall due to a packaging bug in 8.10 - server folks are looking into it; I've added a workaround in main (#3145), but I don't think this branch includes that yet; basically: don't panic if Windows CI fails in truly epic ways)

[doosterkamp]

super close now;

Does not feel like it :P
Testing in our setup fails during handshake (sees serverType == ServerType.Standalone), trying to fix this now

sorry to be pedantic on some of these - I'm not trying to frustrate you

Don't worry about that! Better safe than sorry ...

[doosterkamp]

I moved back to overwriting the user/pw with the Sentinel credentials in the SentinelPrimaryConnect(Async) method in the ConnectionMultiplexer(.Sentinel). Even though I'm not a big fan of the use of Clone(), this is simply working well in my environment.

I tried to implement the usage of the Sentinel credentials in the HandshakeAsync method (in ServerEndPoint), but I lose track of the origin of the call in spaghetti chain of calls leading to the handshake.
Yes, I can see if the configuration is a Sentinel setup (using the created IsSentinel property), but not if it's originated from sentinelPrimaryConnect (which needs the Sentinel credentials in the handshake) of GetSentinelMasterConnection (which needs the Redis credentials in the handshake). After a few days of trying and debugging I gave up and reverted back to my first solution.

Maybe this can be accepted as a stable and working solution (tested this build thorough in our corporate OTA environment), as we really need this solution in the short term.

[mgravell]

OK; we do need the using directive that got culled, for Experimental - let me see if I can push to the branch...

[mgravell]

(sorry for force-push; repairing after a git identity failure)

[mgravell]

https://github.com/StackExchange/StackExchange.Redis/releases/tag/3.1.13

[doosterkamp]

Thank you for the quick responses, feedback and release.