Fix: workaround for crop preview images are too wide to be displayed. - #28
Open
frischnetz wants to merge 1 commit into
Open
frischnetz wants to merge 1 commit into
frischnetz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In recent MODX versions the crop previews in the cropper window are empty for large images.
In the HTML the width of the preview areas are set to the width of the original image, not to the width of the crop-preview-area. This leads to images being outside the crop preview and thus an empty field with only checkerboard patterns.
(The best fix would be to prevent the width from being written into a style tag in the html. This is just a small workaround to get the images displayed again.)