Fix: linux-readline platform only set when using Lua 5.4.x - #51
Conversation
0c0fdfa to
78ca0e3
Compare
|
I tried upgrading |
78ca0e3 to
9dba7ac
Compare
There was a problem hiding this comment.
Pull request overview
Restricts linux-readline to Lua 5.4.x and supports Lua 5.5’s dynamic readline loading.
Changes:
- Adds Lua 5.4.x version detection.
- Uses the standard
linuxtarget on Linux. - Updates readline documentation.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
README.md |
Clarifies readline behavior for Lua 5.4.x. |
bin/install |
Revises platform target selection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| If you are installing Lua 5.4.x or greater on linux by default Lua will be compiled without readline. You can override this behavior by setting `ASDF_LUA_LINUX_READLINE=1` before running `asdf install`. See this thread for the details - http://lua-users.org/lists/lua-l/2020-07/msg00363.html | ||
| If you are installing Lua 5.4.x on Linux, Lua will be compiled without | ||
| readline. |
There was a problem hiding this comment.
Formatting seems a little off here.
Also might be good to note that 5.1 to 5.3 require readline, and 5.5.x and newer will have readline support dynamically included, so if you want readline make sure it's installed before installing lua.
Stratus3D
left a comment
Stratus3D
left a comment
There was a problem hiding this comment.
Overall looks good to me but I think the details on readline should be added to the readme.
|
Thanks for the PR @justiceenunciate ! |
Description
I noticed that installing Lua 5.5.0 when using the
ASDF_LUA_LINUX_READLINEenvironment variable would fail and complain about a missing target:After reading through the Changelog I noticed that readline is loaded dynamically as of 5.5.0. I also pulled down the archive to confirm that
linux-readlineis no longer a target in the Makefile.Changes
linux-readlinetarget only works when Lua version is 5.4.x and ASDF_LUA_LINUX_READLINE is set to 1linuxas the Makefile target whenuname -ris set tolinux(This might be a mistake)Other thoughts
I'm not 100% sure if uname -r will always return "Linux" when on Linux, but it seemed odd to me that we fallback to Linux based on the Lua version, then finally back to
guess. This might put other distributions intoguessmore often, but I have a hunch that this is less fallible than the alternative. Let me know if this was a mistake though!