Skip to content

fix: count only confirmed participants in the event hero (issue #184) - #193

Merged
caviri merged 1 commit into
developfrom
fix/feedback-batch3-20260819
Aug 19, 2026
Merged

fix: count only confirmed participants in the event hero (issue #184)#193
caviri merged 1 commit into
developfrom
fix/feedback-batch3-20260819

Conversation

@caviri

@caviri caviri commented Aug 19, 2026

Copy link
Copy Markdown
Member

#4 (Thibaut, issue #184) — the event header derived participantCount from hackathon.members.length, which includes waitlisted members. A waitlisted person hasn't joined yet, so the headline "N participants" over-counted for every viewer, admins included. Now filters is_waiting; the roster still lists waitlisted people — this is the count, not the list.

Verified: svelte-check 0 errors.


On the rest of this batch (reported honestly, not guessed)

  • feat: add grpc backend with auth #7 View→404: searched every "View" literal, phase-detail links, and capability hrefs — none is a phase "View" that 404s. The only phase-conditional 404 is the phase-edit page (reached with a real phaseId). Needs a live repro to locate the exact control.
  • feat: add pnpm to toolchain #6 propose-when-disabled 500: the backend does gate Propose on the capability + window; the 500 is in the write path with the capability allowed (UNGOVERNED reads as allowed — same coupling as Add frontend sveltekit setup #8). The team's own triager couldn't reproduce the 500 (feedback note [c]). Needs a repro to catch it.

The event header derived participantCount from hackathon.members.length, which
includes waitlisted members. A waitlisted person has not joined yet, so the
headline "N participants" over-counted for every viewer, admins included (issue
#184). Filter out is_waiting; the roster still lists them — this is the count,
not the list.
@caviri
caviri merged commit adfb69b into develop Aug 19, 2026
1 check passed
@caviri
caviri deleted the fix/feedback-batch3-20260819 branch August 19, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant