fix: count only confirmed participants in the event hero (issue #184) - #193
Merged
Conversation
The event header derived participantCount from hackathon.members.length, which includes waitlisted members. A waitlisted person has not joined yet, so the headline "N participants" over-counted for every viewer, admins included (issue #184). Filter out is_waiting; the roster still lists them — this is the count, not the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4 (Thibaut, issue #184) — the event header derived
participantCountfromhackathon.members.length, which includes waitlisted members. A waitlisted person hasn't joined yet, so the headline "N participants" over-counted for every viewer, admins included. Now filtersis_waiting; the roster still lists waitlisted people — this is the count, not the list.Verified: svelte-check 0 errors.
On the rest of this batch (reported honestly, not guessed)