ci(.github/workflows/autofix): match only the subject in the autofix commit guard by sukvvon · Pull Request #11528 · TanStack/query

sukvvon · 2026-09-17T16:53:47Z

🎯 Changes

The guard added in #11522 skipped its own merge, so reference docs were never regenerated on main.

head_commit.message is the full message, not just the subject. A squash merge lists the branch's commits in the body, so any pull request autofix had touched carries * ci: apply automated fixes there and contains matched it:

ci(*): generate reference docs in autofix and fail on TypeDoc conversion errors (#11522)

* ci(.github/workflows/autofix): run 'generate-docs' to keep reference docs current
* ci: apply automated fixes        ← matched here
* fix(scripts/generate-docs): build referenced packages and fail on TypeDoc conversion errors
* ci: apply automated fixes        ← and here

Since autofix runs on nearly every pull request, this would have skipped most merges — not just this one. TanStack/form, which the guard was modelled on, shows the same symptom: of its last 15 skipped runs, 5 were ordinary merges (Form Groups (#2128), Fix trusted provenance (#2194), …) rather than autofix's own commits.

startsWith against the full commit-message matches the subject only, which is what the guard intends:

Head commit	`contains`	`startsWith`
`ci: apply automated fixes`	skip	skip
`ci(*): … (#11522)` with autofix in the body	skip	run
`fix(query-core): … (#11524)`	run	run

The expression is quoted because the literal now contains : , which YAML would otherwise read as a nested mapping.

main currently has seven stale QueryCache.md pages from #11524; merging this should have autofix regenerate them.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have run pnpm run generate-docs and committed the result, or this pull request does not change any JSDoc on published APIs.
I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Automated fixes now run correctly for squash-merge pushes, while still skipping commits explicitly created by the automated-fix process.
- Manual runs of the automated-fix workflow continue to execute as expected.

…commit guard

coderabbitai · 2026-09-17T16:54:13Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a1166b9a-6594-4658-8c2b-7b894999a9c0

📥 Commits

Reviewing files that changed from the base of the PR and between 66d4fe3 and 9ee7bff.

📒 Files selected for processing (1)

.github/workflows/autofix.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The autofix workflow now skips pushes whose commit subject starts with ci: apply automated fixes. Manual workflow_dispatch runs remain unconditional. Pushes that only mention the autofix commit in the message body no longer skip the job.

Changes

Autofix workflow

Layer / File(s)	Summary
Autofix job trigger condition `.github/workflows/autofix.yml`	The job uses `startsWith` on the push commit message and matches the exact `ci: apply automated fixes` prefix. Manual dispatch runs continue to execute.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: tannerlinsley

Merge Risk: ⚪ Minimal · up to 9ee7b

The workflow change is narrowly scoped and has no established merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: updating the autofix workflow guard to match only the commit subject.
Description check	✅ Passed	The description explains the problem, motivation, implementation, expected effect, testing status, and release impact. It includes all required template sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-09-17T16:55:26Z

View your CI Pipeline Execution ↗ for commit 9ee7bff

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 37s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-17 16:58:57 UTC

github-actions · 2026-09-17T16:56:37Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 24 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/query-core`	5.103.1 → 5.103.2	Changeset
`@tanstack/angular-query-experimental`	5.103.1 → 5.103.2	Dependent
`@tanstack/angular-query-persist-client`	5.103.1 → 5.103.2	Dependent
`@tanstack/eslint-plugin-query`	5.103.1 → 5.103.2	Dependent
`@tanstack/lit-query`	0.2.22 → 0.2.23	Dependent
`@tanstack/preact-query`	5.103.1 → 5.103.2	Dependent
`@tanstack/preact-query-devtools`	5.103.1 → 5.103.2	Dependent
`@tanstack/preact-query-persist-client`	5.103.1 → 5.103.2	Dependent
`@tanstack/query-async-storage-persister`	5.103.1 → 5.103.2	Dependent
`@tanstack/query-broadcast-client-experimental`	5.103.1 → 5.103.2	Dependent
`@tanstack/query-devtools`	5.103.1 → 5.103.2	Dependent
`@tanstack/query-persist-client-core`	5.103.1 → 5.103.2	Dependent
`@tanstack/query-sync-storage-persister`	5.103.1 → 5.103.2	Dependent
`@tanstack/react-query`	5.103.1 → 5.103.2	Dependent
`@tanstack/react-query-devtools`	5.103.1 → 5.103.2	Dependent
`@tanstack/react-query-next-experimental`	5.103.1 → 5.103.2	Dependent
`@tanstack/react-query-persist-client`	5.103.1 → 5.103.2	Dependent
`@tanstack/solid-query`	5.103.1 → 5.103.2	Dependent
`@tanstack/solid-query-devtools`	5.103.1 → 5.103.2	Dependent
`@tanstack/solid-query-persist-client`	5.103.1 → 5.103.2	Dependent
`@tanstack/svelte-query`	6.2.1 → 6.2.2	Dependent
`@tanstack/svelte-query-devtools`	6.2.1 → 6.2.2	Dependent
`@tanstack/svelte-query-persist-client`	6.2.1 → 6.2.2	Dependent
`@tanstack/vue-query`	5.103.1 → 5.103.2	Dependent
`@tanstack/vue-query-devtools`	6.2.1 → 6.2.2	Dependent

pkg-pr-new · 2026-09-17T16:56:50Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11528

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11528

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11528

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11528

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11528

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11528

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11528

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11528

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11528

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11528

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11528

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11528

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11528

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11528

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11528

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11528

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11528

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11528

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11528

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11528

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11528

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11528

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11528

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11528

commit: 9ee7bff

github-actions · 2026-09-17T16:57:05Z

size-limit report 📦

Path	Size
react full	11.87 KB (0%)
react minimal	8.85 KB (0%)

ci(.github/workflows/autofix): match only the subject in the autofix …

9ee7bff

…commit guard

sukvvon requested a review from a team as a code owner September 17, 2026 16:53

sukvvon self-assigned this Sep 17, 2026

sukvvon requested a review from TkDodo September 17, 2026 16:55

SeanCassiere approved these changes Sep 18, 2026

View reviewed changes

sukvvon merged commit a66c797 into main Sep 18, 2026
9 checks passed

sukvvon deleted the ci/autofix-guard-match-subject-only branch September 18, 2026 00:41

Navigation Menu

Uh oh!

ci(.github/workflows/autofix): match only the subject in the autofix commit guard - #11528

ci(.github/workflows/autofix): match only the subject in the autofix commit guard#11528
sukvvon merged 1 commit into
mainfrom
ci/autofix-guard-match-subject-only

sukvvon commented Sep 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

pkg-pr-new Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sukvvon commented Sep 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 17, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

pkg-pr-new Bot commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sukvvon commented Sep 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 17, 2026 •

edited

Loading

nx-cloud Bot commented Sep 17, 2026 •

edited

Loading