Return valid empty frame for FlexRay WUS/CAS symbols - #30
Open
RayanMRABET wants to merge 2 commits into
Open
Conversation
Author
|
Hi @kayoub5 could you please review? |
kayoub5
reviewed
Aug 16, 2026
| @@ -84,6 +84,18 @@ int tecmp_next( | |||
|
|
|||
| // Possible Ethernet padding | |||
| if (!header->length) { | |||
Member
There was a problem hiding this comment.
instead of all the flexray specific logic, change this check to test on timestamp being non zero in addition to the length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tecmp_nextreturnedENODATAwheneverheader->length == 0, treating it asEthernet padding. This is wrong for FlexRay wake-up (WUS) and collision-avoidance
(CAS) symbols, which legitimately carry no payload and therefore have a zero
Lengthfield.This change makes
tecmp_nextreturn a valid frame with an empty payload whendata_type == TECMP_DATA_FLEXRAYand theTECMP_FR_WUS/TECMP_FR_CASdata-flagsare set, so consumer code no longer has to special-case
ENODATA. It also exposesTECMP_FR_WUSandTECMP_FR_CASintecmp.h.