pdn: check via enclosure and try again when merging changes width - #11212
Open
gadfort wants to merge 3 commits into
Open
pdn: check via enclosure and try again when merging changes width#11212gadfort wants to merge 3 commits into
gadfort wants to merge 3 commits into
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the via generation logic in the PDN module to correctly handle width-conditioned rules on shared routing layers in a via stack by iteratively rebuilding the stack based on the merged metal widths. It also transitions via storage to use std::unique_ptr for safer memory management. The review feedback suggests several improvements: updating getLowerHeight and getUpperHeight to handle horizontal shared routing layers, resolving signed/unsigned comparison warnings by using size_t in loops, adding a maximum iteration limit to the rebuilding loop to prevent infinite loops, and adding default member initializers to the Constraint struct to avoid uninitialized variables.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11129
Iteratively resolves the stacked vias to ensure they are re-evaluated on changes.
Type of Change
Impact
Verification
./etc/Build.sh).Related Issues
#11129