pdn: various fixes to follow pin handling - #11216
Open
gadfort wants to merge 7 commits into
Open
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the PDN generation logic to support mirrored and multi-height standard cell rows. It introduces a method to determine the row pitch based on the minimum row height and refactors followpin shape generation to iterate over the row height. Feedback on the changes highlights two critical issues: a potential null pointer dereference if a row lacks a valid site in determinePitch, and a potential infinite loop in makeShapes if row_height_ is zero.
gadfort
marked this pull request as draft
August 24, 2026 12:10
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
gadfort
marked this pull request as ready for review
August 24, 2026 14:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the incorrect double VSS straps in the power switch tests.
Type of Change
Impact
Correct followpin ordering.
Verification
./etc/Build.sh).Related Issues
#10955