Skip to content

pdn: various fixes to follow pin handling - #11216

Open
gadfort wants to merge 7 commits into
The-OpenROAD-Project:masterfrom
gadfort:pdn-followpins
Open

pdn: various fixes to follow pin handling#11216
gadfort wants to merge 7 commits into
The-OpenROAD-Project:masterfrom
gadfort:pdn-followpins

Conversation

@gadfort

@gadfort gadfort commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  1. Account for MY rows orientations
  2. ensure the smaller row pitch is selected, not just the first
  3. use row height to add followpins to better account for non-1x row heights
    Fixes the incorrect double VSS straps in the power switch tests.

Type of Change

  • Bug fix

Impact

Correct followpin ordering.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Related Issues

#10955

Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
@gadfort
gadfort requested a review from a team as a code owner August 24, 2026 00:38
@gadfort
gadfort requested a review from maliberty August 24, 2026 00:38

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the PDN generation logic to support mirrored and multi-height standard cell rows. It introduces a method to determine the row pitch based on the minimum row height and refactors followpin shape generation to iterate over the row height. Feedback on the changes highlights two critical issues: a potential null pointer dereference if a row lacks a valid site in determinePitch, and a potential infinite loop in makeShapes if row_height_ is zero.

Comment thread src/pdn/src/straps.cpp
Comment thread src/pdn/src/straps.cpp Outdated
@gadfort
gadfort marked this pull request as ready for review August 24, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant