fix: manually bind textobject select keymaps - #153
Open
patrickcchenn wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change matches the new plugin API and is functionally straightforward, with only a minor naming nit noted.
Pull request overview
Updates the nvim-treesitter-textobjects configuration to restore af / if function textobject selection after the plugin’s API rewrite, by removing deprecated config keys and binding the keymaps explicitly.
Changes:
- Removes deprecated
select.enableandselect.keymapsoptions fromnvim-treesitter-textobjects.setup(). - Adds manual
af/ifmappings that callrequire("nvim-treesitter-textobjects.select").select_textobject(...).
File summaries
| File | Description |
|---|---|
| lua/theprimeagen/lazy/treesitter.lua | Drops removed config keys and manually binds af/if using the new textobjects selection API. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+54
to
+61
| local select = require("nvim-treesitter-textobjects.select") | ||
|
|
||
| vim.keymap.set({ "x", "o" }, "af", function() | ||
| select.select_textobject("@function.outer", "textobjects") | ||
| end) | ||
| vim.keymap.set({ "x", "o" }, "if", function() | ||
| select.select_textobject("@function.inner", "textobjects") | ||
| end) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
af/iftext object selection stopped working. Thenvim-treesitter-textobjectsconfig was using the oldselect.keymapstable, which was removed in the plugin's
mainbranch rewrite. Config key is silently ignored — no error, but no keymaps either.Fix
enable/keymapsfromsetup()(no longer valid options).af/ifmanually viarequire("nvim-treesitter-textobjects.select").select_textobject(...),as required by the new API.