Guard missing platform font fallback - #88
Merged
Merged
Conversation
Try
reviewed
Sep 1, 2026
| // stbtt_InitFont is undefined behaviour (and crashes on iOS/macOS). | ||
| if(path.empty()) | ||
| return nullLater(); | ||
| fallback.reset(new Impl(path)); |
Owner
There was a problem hiding this comment.
This line causes extra copy of std::string. Explicit conversion of path to std::string_view can fix it.
Contributor
Author
There was a problem hiding this comment.
Thanks, good catch. I've changed it to std::string_view(path) and updated the test to use U+200B so it actually hits the empty fallback path. All 175 tests pass.
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms without a configured system font fallback return an empty fallback path. The current implementation may then attempt to initialize
stb_truetypeusing an empty font buffer.This change safely returns an empty glyph when no fallback is available and validates the font data before initializing it. A regression test covers this case.
Testing: