Fix CTest registration for TempestTests - #93
Merged
Conversation
Owner
|
look good - merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
add_testcall mixes the legacy signature with theCOMMANDkeyword. As a result, CTest treatsCOMMANDas the executable name and fails withTempestTests: command not found.Use the
NAME ... COMMAND ...signature so CMake resolves the test target to its configuration-specific executable path. Run it from the existing runtime output directory, where the test assets and generated shaders are available.Validation:
The current GitHub Actions workflow invokes
TempestTestsdirectly, so this change affects CTest registration rather than the existing CI command.