Fix iOS autorelease pool lifetime across fiber yields - #94
Open
tryk016 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS backend currently keeps a local autorelease pool alive while it dispatches an engine event. An event callback can call
processEvents()again, yield to UIKit and let the surrounding run-loop pool drain before the engine fiber resumes. Popping the local pool after that can trigger an autorelease-poolbadPopcrash.Remove only the pool that spans event dispatch. UIKit still provides the autorelease pool for each event-loop iteration, and the short pool used by the render callback is unchanged.
Validation:
processEvents()without a crash