Skip to content

Fix iOS view controller initialization and ownership - #96

Open
tryk016 wants to merge 1 commit into
Try:masterfrom
tryk016:codex/pr-tempest-ios-view-controller
Open

Fix iOS view controller initialization and ownership#96
tryk016 wants to merge 1 commit into
Try:masterfrom
tryk016:codex/pr-tempest-ios-view-controller

Conversation

@tryk016

@tryk016 tryk016 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The iOS view controller initializer currently skips [super init], and its viewDidLoad override does not call the superclass implementation. The app delegate also keeps the +1 ownership returned by [ViewController new] after assigning it to the retaining rootViewController property.

Use the normal UIKit initialization chain, call [super viewDidLoad] and balance the temporary controller ownership after assignment. Rename the fullscreen setter argument to avoid shadowing the ivar.

Validation:

  • Release builds pass for iPhoneOS arm64 and iPhone Simulator arm64 at iOS 15.0
  • Clang static analysis is clean for the controller initialization and ownership path
  • the integrated build starts, backgrounds and resumes successfully on an iPhone 15 Pro Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant