chore: remove leaked test artifacts from repo root - #1365
Merged
Conversation
`.RAN_TEARDOWN` and `.setup` are empty files swept into 40560c2 by a `git add -A`, not something the project uses. Nothing reads them: `git log -S'RAN_TEARDOWN' --all` finds no commit whose content ever mentioned the name, and `.setup` is what a dev-time run of the #1324 timeout test wrote into the working directory back when its fixture expanded `"$TIMEOUT_MARKER.setup"` with the marker unset. The test now sets `TIMEOUT_MARKER` to a path under `bashunit::temp_dir`, so neither file is regenerated. They shipped in no artifact -- `package.json` lists only `bin/bashunit`, `LICENSE` and `README.md`, and `bpkg.json` only `bashunit` -- so this is repo hygiene, not a release fix. No `.gitignore` entry to go with it: a rule guarding a name nothing writes is the same false landmark in another file. Claude-Session: https://claude.ai/code/session_01EXYWTGLjf7qM8Ru3GakDRm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
.RAN_TEARDOWNand.setupare two empty files sitting at the repo root. Nothing in the project uses them — they were swept into 40560c2 by agit add -Awhile #1329 was being fixed. Two 0-byte files that look deliberate cost the next contributor a grep to find out they are not.💡 Changes
git log -S'RAN_TEARDOWN' --allfinds no commit whose content ever mentioned the name, and.setupis what a dev-time run of the A test killed by--test-timeoutdoes not runtear_down#1324 timeout test wrote into the working directory back when its fixture expanded"$TIMEOUT_MARKER.setup"with the marker unset.TIMEOUT_MARKERat a path underbashunit::temp_dir, and the sequential and--parallelsuites both finish clean without them..gitignoreentry to go with it — a rule guarding a name nothing writes is the same false landmark in another file.package.jsonlists onlybin/bashunit,LICENSEandREADME.md, andbpkg.jsononlybashunit.https://claude.ai/code/session_01EXYWTGLjf7qM8Ru3GakDRm